Page MenuHomePhabricator

sharesafe: introduce config to disallow outdated shares if upgrade fails
ClosedPublic

Authored by pulkit on Fri, Jan 8, 11:24 AM.

Details

Summary

After this patch, we have config option to control all aspects of shares
when share source is upgraded or downgraded.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Fri, Jan 8, 11:24 AM
marmoute requested changes to this revision.Fri, Jan 8, 9:46 PM
marmoute added a subscriber: marmoute.
marmoute added inline comments.
mercurial/localrepo.py
611–618 ↗(On Diff #24646)

We will want the abort to get into play when the upgrade was tried, but failed.

This revision now requires changes to proceed.Fri, Jan 8, 9:46 PM
baymax retitled this revision from sharesafe: introduce config to disallow outdated shares from working to sharesafe: introduce config to disallow outdated shares if upgrade fails.Sat, Jan 9, 8:03 AM
baymax updated this revision to Diff 24697.

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit added a comment.Sat, Jan 9, 2:10 PM

Incorporated the suggestion.

Alphare accepted this revision.Tue, Jan 12, 11:42 AM
Alphare added a subscriber: Alphare.

This looks good on its own, but I haven't seen any user-facing documentation/help text for the config options. Please send a follow-up.

pulkit updated this revision to Diff 24779.Wed, Jan 13, 6:30 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.