Page MenuHomePhabricator

outgoing: pass subrepo path using function argument instead of abssource hack
ClosedPublic

Authored by marmoute on Apr 13 2021, 8:36 PM.

Details

Summary

This is clearer, remove the needs for the repo._subtoppath hack and will make
our live easier when making outgoing accept multiple destinations.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Apr 13 2021, 8:36 PM
baymax updated this revision to Diff 26846.Apr 13 2021, 9:10 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit added a subscriber: pulkit.Apr 14 2021, 7:47 PM
pulkit added inline comments.
mercurial/subrepoutil.py
386 ↗(On Diff #26846)

Hm, this looks like an unrelated change in this patch.

marmoute added inline comments.Apr 15 2021, 3:00 AM
mercurial/subrepoutil.py
386 ↗(On Diff #26846)

No, this is the function we need to achieve the goal o this patch. I can extract it in its own patch if you prefer.

pulkit accepted this revision.Apr 15 2021, 7:43 AM
This revision is now accepted and ready to land.Apr 15 2021, 7:43 AM