| Alphare | |
| pulkit |
| hg-reviewers |
It appears pushurl only support <proto>:// entries. This is not obvious and
can lead to obscure error. We make the error less obscure as a start..
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| Path | Packages | |||
|---|---|---|---|---|
| M | mercurial/utils/urlutil.py (4 lines) | |||
| M | tests/test-paths.t (2 lines) |
| return register | return register | ||||
| @pathsuboption(b'pushurl', b'pushloc') | @pathsuboption(b'pushurl', b'pushloc') | ||||
| def pushurlpathoption(ui, path, value): | def pushurlpathoption(ui, path, value): | ||||
| u = url(value) | u = url(value) | ||||
| # Actually require a URL. | # Actually require a URL. | ||||
| if not u.scheme: | if not u.scheme: | ||||
| ui.warn(_(b'(paths.%s:pushurl not a URL; ignoring)\n') % path.name) | msg = _(b'(paths.%s:pushurl not a URL; ignoring: "%s")\n') | ||||
| msg %= (path.name, value) | |||||
| ui.warn(msg) | |||||
| return None | return None | ||||
| # Don't support the #foo syntax in the push URL to declare branch to | # Don't support the #foo syntax in the push URL to declare branch to | ||||
| # push. | # push. | ||||
| if u.fragment: | if u.fragment: | ||||
| ui.warn( | ui.warn( | ||||
| _( | _( | ||||
| b'("#fragment" in paths.%s:pushurl not supported; ' | b'("#fragment" in paths.%s:pushurl not supported; ' | ||||
| $ cat > .hg/hgrc << EOF | $ cat > .hg/hgrc << EOF | ||||
| > [paths] | > [paths] | ||||
| > default = /path/to/nothing | > default = /path/to/nothing | ||||
| > default:pushurl = /not/a/url | > default:pushurl = /not/a/url | ||||
| > EOF | > EOF | ||||
| $ hg paths | $ hg paths | ||||
| (paths.default:pushurl not a URL; ignoring) | (paths.default:pushurl not a URL; ignoring: "/not/a/url") | ||||
| default = /path/to/nothing | default = /path/to/nothing | ||||
| #fragment is not allowed in :pushurl | #fragment is not allowed in :pushurl | ||||
| $ cat > .hg/hgrc << EOF | $ cat > .hg/hgrc << EOF | ||||
| > [paths] | > [paths] | ||||
| > default = https://example.com/repo | > default = https://example.com/repo | ||||
| > invalid = https://example.com/repo | > invalid = https://example.com/repo | ||||