This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10436

perfphasesremote: use `get_unique_push_path` if available
AbandonedPublic

Authored by marmoute on Apr 15 2021, 4:52 AM.

Details

Reviewers
pulkit
Alphare
Group Reviewers
hg-reviewers
Summary

After ui.expandpath we are not after getpath (that will be much simpler). The reason is still the fact we can't rely on getting a single url from a single path anymore.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Apr 15 2021, 4:52 AM
pulkit accepted this revision.Apr 19 2021, 6:31 AM
This revision is now accepted and ready to land.Apr 19 2021, 6:31 AM
Alphare accepted this revision.Apr 20 2021, 10:37 AM
pulkit added a comment.May 3 2021, 5:50 AM

IIRC, applying this one was resulting in content divergence. Can you have a look?

marmoute added a comment.May 3 2021, 7:48 AM
In D10436#160401, @pulkit wrote:

IIRC, applying this one was resulting in content divergence. Can you have a look?

I can… but I don't have the divergence in my repository yet, so I don't know that you expect of me. Can you clarify your request ?

marmoute added a comment.May 3 2021, 7:54 AM
In D10436#160731, @marmoute wrote:
In D10436#160401, @pulkit wrote:

IIRC, applying this one was resulting in content divergence. Can you have a look?

I can… but I don't have the divergence in my repository yet, so I don't know that you expect of me. Can you clarify your request ?

okay, I just realised it was a isolated patch and not part of the other series related to path. It look like this patch was folded and that phabricator does not realise this king of things.

marmoute abandoned this revision.May 3 2021, 7:54 AM

Revision Contents
Changeset List

PathPackages
Mcontrib/perf.py (8 lines)

Diff 26923

contrib/perf.py

exchange, exchange,
hg, hg,
phases, phases,
) )
opts = _byteskwargs(opts) opts = _byteskwargs(opts)
timer, fm = gettimer(ui, opts) timer, fm = gettimer(ui, opts)
try:
from mercurial.utils.urlutil import get_unique_push_path
path = get_unique_push_path(repo, ui, dest)
except ImportError:
path = ui.getpath(dest, default=(b'default-push', b'default')) path = ui.getpath(dest, default=(b'default-push', b'default'))
if not path: if not path:
raise error.Abort( raise error.Abort(
b'default repository not configured!', b'default repository not configured!',
hint=b"see 'hg help config.paths'", hint=b"see 'hg help config.paths'",
) )
dest = path.pushloc or path.loc dest = path.pushloc or path.loc
ui.statusnoi18n(b'analysing phase of %s\n' % util.hidepassword(dest)) ui.statusnoi18n(b'analysing phase of %s\n' % util.hidepassword(dest))
other = hg.peer(repo, opts, dest) other = hg.peer(repo, opts, dest)