Page MenuHomePhabricator

perf-discovery: use `get_unique_pull_path`
ClosedPublic

Authored by marmoute on Apr 14 2021, 7:39 PM.

Details

Summary

This performance command now use the new API, unless the benchmarked Mercurial
is older.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Apr 14 2021, 7:39 PM
pulkit accepted this revision.Apr 17 2021, 4:54 PM
pulkit added a subscriber: pulkit.
pulkit added inline comments.
contrib/perf.py
924

should it be pass instead? Else IIUC, we should drop the next path = ... statement.

This revision is now accepted and ready to land.Apr 17 2021, 4:54 PM
pulkit requested changes to this revision.Apr 17 2021, 4:54 PM
This revision now requires changes to proceed.Apr 17 2021, 4:54 PM
marmoute added inline comments.Apr 17 2021, 5:08 PM
contrib/perf.py
924

We should drop the raise. I guess I used it for checking of forgot it there. Thank for spotting this out.

This revision was not accepted when it landed; it landed in state Needs Revision.
This revision was automatically updated to reflect the committed changes.