This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10423

perf-discovery: use `get_unique_pull_path`
ClosedPublic

Authored by marmoute on Apr 14 2021, 7:39 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG92029a43debb: perf-discovery: use `get_unique_pull_path`
Summary

This performance command now use the new API, unless the benchmarked Mercurial
is older.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Apr 14 2021, 7:39 PM
pulkit accepted this revision.Apr 17 2021, 4:54 PM
pulkit added a subscriber: pulkit.
pulkit added inline comments.
contrib/perf.py
924

should it be pass instead? Else IIUC, we should drop the next path = ... statement.

This revision is now accepted and ready to land.Apr 17 2021, 4:54 PM
pulkit requested changes to this revision.Apr 17 2021, 4:54 PM
This revision now requires changes to proceed.Apr 17 2021, 4:54 PM
marmoute added inline comments.Apr 17 2021, 5:08 PM
contrib/perf.py
924

We should drop the raise. I guess I used it for checking of forgot it there. Thank for spotting this out.

marmoute added a commit: rHG92029a43debb: perf-discovery: use `get_unique_pull_path`.Apr 17 2021, 6:13 PM
This revision was not accepted when it landed; it landed in state Needs Revision.
Closed by commit rHG92029a43debb: perf-discovery: use `get_unique_pull_path` (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/perf.py (9 lines)

Diff 26879

contrib/perf.py

fm.end() fm.end()
@command(b'perf::discovery|perfdiscovery', formatteropts, b'PATH') @command(b'perf::discovery|perfdiscovery', formatteropts, b'PATH')
def perfdiscovery(ui, repo, path, **opts): def perfdiscovery(ui, repo, path, **opts):
"""benchmark discovery between local repo and the peer at given path""" """benchmark discovery between local repo and the peer at given path"""
repos = [repo, None] repos = [repo, None]
timer, fm = gettimer(ui, opts) timer, fm = gettimer(ui, opts)
try:
from mercurial.utils.urlutil import get_unique_pull_path
path = get_unique_pull_path(b'perfdiscovery', repo, ui, path)[0]
except ImportError:
raise
pulkitUnsubmitted
Not Done

should it be pass instead? Else IIUC, we should drop the next path = ... statement.

pulkit: should it be `pass` instead? Else IIUC, we should drop the next `path = ...` statement.
marmouteAuthorUnsubmitted
Done

We should drop the raise. I guess I used it for checking of forgot it there. Thank for spotting this out.

marmoute: We should drop the raise. I guess I used it for checking of forgot it there. Thank for spotting…
path = ui.expandpath(path) path = ui.expandpath(path)
def s(): def s():
repos[1] = hg.peer(ui, opts, path) repos[1] = hg.peer(ui, opts, path)
def d(): def d():
setdiscovery.findcommonheads(ui, *repos) setdiscovery.findcommonheads(ui, *repos)
timer(d, setup=s) timer(d, setup=s)