This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10403

urlutil: add a new `get_unique_pull_path`
ClosedPublic

Authored by marmoute on Apr 14 2021, 7:37 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG1998a8311c48: urlutil: add a new `get_unique_pull_path`
Summary

This function is dedicated to call that needs a single destination. Currently most caller actually need that since few actually support multiple destinations (the most importants hg push and hg outgoing do). So having a clear API point for that will be important when the time comes to have a single [paths] alias resolving to multiple urls.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Apr 14 2021, 7:37 PM
pulkit accepted this revision.Apr 15 2021, 7:48 AM
This revision is now accepted and ready to land.Apr 15 2021, 7:48 AM
marmoute added a commit: rHG1998a8311c48: urlutil: add a new `get_unique_pull_path`.Apr 15 2021, 9:46 AM
Closed by commit rHG1998a8311c48: urlutil: add a new `get_unique_pull_path` (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/utils/urlutil.py (16 lines)

Diff 26938

mercurial/utils/urlutil.py

"""yields all the `(path, branch)` selected as pull source by `sources`""" """yields all the `(path, branch)` selected as pull source by `sources`"""
if not sources: if not sources:
sources = [b'default'] sources = [b'default']
for source in sources: for source in sources:
url = ui.expandpath(source) url = ui.expandpath(source)
yield parseurl(url, default_branches) yield parseurl(url, default_branches)
def get_unique_pull_path(action, repo, ui, source=None, default_branches=()):
"""return a unique `(path, branch)` or abort if multiple are found
This is useful for command and action that does not support multiple
destination (yet).
Note that for now, we cannot get multiple destination so this function is "trivial".
The `action` parameter will be used for the error message.
"""
if source is None:
source = b'default'
url = ui.expandpath(source)
return parseurl(url, default_branches)
def get_clone_path(ui, source, default_branches=()): def get_clone_path(ui, source, default_branches=()):
"""return the `(origsource, path, branch)` selected as clone source""" """return the `(origsource, path, branch)` selected as clone source"""
url = ui.expandpath(source) url = ui.expandpath(source)
path, branch = parseurl(url, default_branches) path, branch = parseurl(url, default_branches)
return url, path, branch return url, path, branch
def parseurl(path, branches=None): def parseurl(path, branches=None):