Page MenuHomePhabricator

incoming: kill the `repo._subtoppath =` hack
ClosedPublic

Authored by marmoute on Apr 14 2021, 7:38 PM.

Details

Summary

We do the same as for hg outgoing, instead of relying on implicit passing
value by monkey punching them onto the repo object, we pass equivalent
information by argument to the proper function.

This is way cleaner.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Apr 14 2021, 7:38 PM
marmoute updated this revision to Diff 26919.Apr 15 2021, 3:38 AM
pulkit accepted this revision.Apr 15 2021, 11:14 AM
This revision is now accepted and ready to land.Apr 15 2021, 11:14 AM
This revision was automatically updated to reflect the committed changes.