This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10645

revlog: fix the `null_item` attribute for V0
ClosedPublic

Authored by marmoute on May 4 2021, 10:14 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG013c645dd28c: revlog: fix the `null_item` attribute for V0
Summary

This is not a proper index tuple.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.May 4 2021, 10:14 AM
baymax updated this revision to Diff 27884.May 11 2021, 1:45 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.May 17 2021, 5:49 PM
This revision is now accepted and ready to land.May 17 2021, 5:49 PM
marmoute added a commit: rHG013c645dd28c: revlog: fix the `null_item` attribute for V0.May 17 2021, 5:54 PM
Closed by commit rHG013c645dd28c: revlog: fix the `null_item` attribute for V0 (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/revlogutils/revlogv0.py (2 lines)

Diff 28038

mercurial/revlogutils/revlogv0.py

def offset_type(offset, type): def offset_type(offset, type):
if (type & ~flagutil.REVIDX_KNOWN_FLAGS) != 0: if (type & ~flagutil.REVIDX_KNOWN_FLAGS) != 0:
raise ValueError(b'unknown revlog index flags') raise ValueError(b'unknown revlog index flags')
return int(int(offset) << 16 | type) return int(int(offset) << 16 | type)
class revlogoldindex(list): class revlogoldindex(list):
entry_size = INDEX_ENTRY_V0.size entry_size = INDEX_ENTRY_V0.size
null_item = (0, 0, 0, -1, -1, -1, -1, node.nullid) null_item = (0, 0, 0, -1, -1, -1, -1, sha1nodeconstants.nullid, 0, 0)
@property @property
def nodemap(self): def nodemap(self):
msg = b"index.nodemap is deprecated, use index.[has_node|rev|get_rev]" msg = b"index.nodemap is deprecated, use index.[has_node|rev|get_rev]"
util.nouideprecwarn(msg, b'5.3', stacklevel=2) util.nouideprecwarn(msg, b'5.3', stacklevel=2)
return self._nodemap return self._nodemap
@util.propertycache @util.propertycache