Page MenuHomePhabricator

revlog: adjust rewrite_sidedata code to not delete existing revlog content
ClosedPublic

Authored by marmoute on Sun, May 2, 9:29 AM.

Details

Summary

The "w+" file mode is deleting all the content of the opened file. Which is bad…

This is not caught by the test because the test only check for a full, initial
pull where not pre-existing content exists. So we need to fix our test coverage
here.

However they are another issue that prevent "incremental" pull to work here. See
next changeset for details.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Sun, May 2, 9:29 AM
baymax updated this revision to Diff 27312.Mon, May 3, 6:07 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 27336.Mon, May 3, 7:36 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 27462.Mon, May 3, 9:01 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.Fri, May 7, 8:50 AM
This revision is now accepted and ready to land.Fri, May 7, 8:50 AM