Page MenuHomePhabricator
Differential D10610

revlog: only use the `_indexfp` method for read operation
ClosedPublic
Actions

Authored by marmoute on May 3 2021, 7:53 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGffa8afc5f931: revlog: only use the `_indexfp` method for read operation
Summary

This will avoid "other" code to not overlook _writing usage. We introduces
private method dedicated to writing to make use the right option are always
used.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.May 3 2021, 7:53 AM
baymax updated this revision to Diff 27525.May 3 2021, 9:44 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 27856.May 11 2021, 1:42 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 27982.May 17 2021, 7:02 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute added a commit: rHGffa8afc5f931: revlog: only use the `_indexfp` method for read operation.May 17 2021, 8:56 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGffa8afc5f931: revlog: only use the `_indexfp` method for read operation (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/revlog.py (47 lines)

Diff 28010

View Options

mercurial/revlog.py

Loading...