Details

Reviewers

indygreg
marmoute

Group Reviewers

hg-reviewers

Commits

rHG223b47235d1c: sidedata: enable sidedata computers to optionally rewrite flags

Summary

Sidedata computers may want to influence the flags of the revision they touch.
For example, the computer for changelog-based copytracing can add a flag to
signify that this revision might affect copytracing, inversely removing said
flag if the information is no longer applicable.

See inline documentation in storageutil for more details.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Apr 9 2021, 4:49 AM

Herald added a reviewer: indygreg. · View Herald TranscriptApr 9 2021, 4:49 AM

Herald added a reviewer: hg-reviewers. · View Herald Transcript

Herald added a subscriber: mercurial-patches. · View Herald Transcript

Alphare added a child revision: D10345: bundle2: remove restriction around sidedata.Apr 9 2021, 4:50 AM

marmoute accepted this revision.Apr 9 2021, 6:11 AM

Alphare updated this revision to Diff 26779.Apr 10 2021, 3:14 PM

Alphare updated this revision to Diff 27033.Mon, Apr 19, 6:09 AM

Alphare updated this revision to Diff 27100.Tue, Apr 20, 9:38 AM

marmoute accepted this revision.Thu, Apr 22, 1:46 PM

marmoute added inline comments.

tests/testlib/ext-sidedata-3.py
25	nit: missing `#hoot` comment
tests/testlib/ext-sidedata-5.py
26	nit: missing `#hoot` comment

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare added a commit: rHG223b47235d1c: sidedata: enable sidedata computers to optionally rewrite flags.Wed, May 5, 6:41 PM

This revision was not accepted when it landed; it landed in state Needs Review.

Closed by commit rHG223b47235d1c: sidedata: enable sidedata computers to optionally rewrite flags (authored by Alphare). · Explain Why

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			mercurial/cext/revlog.c (9 lines)
M			mercurial/interfaces/repository.py (2 lines)
M			mercurial/localrepo.py (6 lines)
M			mercurial/metadata.py (5 lines)
M			mercurial/pure/parsers.py (7 lines)
M			mercurial/revlog.py (12 lines)
M			mercurial/utils/storageutil.py (31 lines)
M			tests/testlib/ext-sidedata-2.py (8 lines)
M			tests/testlib/ext-sidedata-3.py (15 lines)
M			tests/testlib/ext-sidedata-5.py (8 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	26753		Apr 9 2021, 4:49 AM	★	★
Diff 2	26779		Apr 10 2021, 3:14 PM	★	★
Diff 3	27033		Mon, Apr 19, 6:09 AM	★	★
Diff 4	27100		Tue, Apr 20, 9:38 AM	★	★
Diff 5	27301		Mon, May 3, 6:06 AM	★	★
Diff 6	27451		Mon, May 3, 9:01 PM	★	★
Diff 7	27604	rHG223b47235d1c7442b8ba2feebe7e8b7bb548d588	Apr 8 2021, 10:55 AM	★	★

sidedata: enable sidedata computers to optionally rewrite flags
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 27604

mercurial/cext/revlog.c

mercurial/interfaces/repository.py

mercurial/localrepo.py

mercurial/metadata.py

mercurial/pure/parsers.py

mercurial/revlog.py

mercurial/utils/storageutil.py

tests/testlib/ext-sidedata-2.py

tests/testlib/ext-sidedata-3.py

tests/testlib/ext-sidedata-5.py

sidedata: enable sidedata computers to optionally rewrite flagsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27604

mercurial/cext/revlog.c

mercurial/interfaces/repository.py

mercurial/localrepo.py

mercurial/metadata.py

mercurial/pure/parsers.py

mercurial/revlog.py

mercurial/utils/storageutil.py

tests/testlib/ext-sidedata-2.py

tests/testlib/ext-sidedata-3.py

tests/testlib/ext-sidedata-5.py

sidedata: enable sidedata computers to optionally rewrite flags
ClosedPublic
Actions

Revision Contents
Changeset List