( )⚙ D10992 dirstate-item: deprecate tuple access on the class

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10992

dirstate-item: deprecate tuple access on the class
ClosedPublic

Authored by marmoute on Jul 5 2021, 5:35 AM.

Details

Reviewers
SimonSapin
Alphare
Group Reviewers
hg-reviewers
Commits
rHG7a4ba68f2373: dirstate-item: deprecate tuple access on the class
Summary

This should help us to catch and update the last user of this, especially in
extensions.

People will need to run the test with --pure to actually catch it, but this is
better than nothing.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jul 5 2021, 5:35 AM
SimonSapin accepted this revision.Jul 5 2021, 6:48 AM
baymax updated this revision to Diff 28847.Jul 6 2021, 1:35 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 28929.Jul 7 2021, 8:01 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 29023.Jul 8 2021, 2:27 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.Jul 9 2021, 11:15 AM
This revision is now accepted and ready to land.Jul 9 2021, 11:15 AM
marmoute added a commit: rHG7a4ba68f2373: dirstate-item: deprecate tuple access on the class.Jul 9 2021, 1:19 PM
Closed by commit rHG7a4ba68f2373: dirstate-item: deprecate tuple access on the class (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/pure/parsers.py (8 lines)

Diff 29048

mercurial/pure/parsers.py

_state = attr.ib() _state = attr.ib()
_mode = attr.ib() _mode = attr.ib()
_size = attr.ib() _size = attr.ib()
_mtime = attr.ib() _mtime = attr.ib()
def __getitem__(self, idx): def __getitem__(self, idx):
if idx == 0 or idx == -4: if idx == 0 or idx == -4:
msg = b"do not use item[x], use item.state"
util.nouideprecwarn(msg, b'6.0', stacklevel=2)
return self._state return self._state
elif idx == 1 or idx == -3: elif idx == 1 or idx == -3:
msg = b"do not use item[x], use item.mode"
util.nouideprecwarn(msg, b'6.0', stacklevel=2)
return self._mode return self._mode
elif idx == 2 or idx == -2: elif idx == 2 or idx == -2:
msg = b"do not use item[x], use item.size"
util.nouideprecwarn(msg, b'6.0', stacklevel=2)
return self._size return self._size
elif idx == 3 or idx == -1: elif idx == 3 or idx == -1:
msg = b"do not use item[x], use item.mtime"
util.nouideprecwarn(msg, b'6.0', stacklevel=2)
return self._mtime return self._mtime
else: else:
raise IndexError(idx) raise IndexError(idx)
@property @property
def mode(self): def mode(self):
return self._mode return self._mode