This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11003

windows: use cpu-intensive task instead of real time in test
ClosedPublic

Authored by Alphare on Jul 7 2021, 9:14 AM.

Details

Reviewers
marmoute
Group Reviewers
hg-reviewers
Commits
rHGdc3f7aa15423: windows: use cpu-intensive task instead of real time in test
Summary

Windows profiling breaks when using real time instead of cpu, but we need the
extension function to show up, so make it do something instead of waiting.
I've also duplicated the test cases so that explicit real and CPU times are
tested (on platforms other than Windows)

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Jul 7 2021, 9:14 AM
marmoute accepted this revision.Jul 7 2021, 11:56 AM
marmoute added a subscriber: marmoute.

Sad but true

Alphare added a commit: rHGdc3f7aa15423: windows: use cpu-intensive task instead of real time in test.Jul 8 2021, 4:20 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGdc3f7aa15423: windows: use cpu-intensive task instead of real time in test (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-profile.t (19 lines)

Diff 29028

tests/test-profile.t

$ cat >> sleepext_with_a_long_filename.py << EOF $ cat >> sleepext_with_a_long_filename.py << EOF
> import time > import time
> from mercurial import registrar > from mercurial import registrar
> cmdtable = {} > cmdtable = {}
> command = registrar.command(cmdtable) > command = registrar.command(cmdtable)
> @command(b'sleep', [], b'hg sleep') > @command(b'sleep', [], b'hg sleep')
> def sleep_for_at_least_one_stat_cycle(ui, *args, **kwargs): > def sleep_for_at_least_one_stat_cycle(ui, *args, **kwargs):
> time.sleep(0.1) > t = time.time() # don't use time.sleep because we need CPU time
> while time.time() - t < 0.5:
> pass
> EOF > EOF
$ cat >> $HGRCPATH << EOF $ cat >> $HGRCPATH << EOF
> [extensions] > [extensions]
> sleep = `pwd`/sleepext_with_a_long_filename.py > sleep = `pwd`/sleepext_with_a_long_filename.py
> EOF > EOF
statistical profiler works statistical profiler works
* sleepext_with_a_long_filename.py:*:sleep_for_at_least_one_stat_cycle (glob) * sleepext_with_a_long_filename.py:*:sleep_for_at_least_one_stat_cycle (glob)
$ cat ../out | statprofran $ cat ../out | statprofran
$ hg --profile --config profiling.statformat=bymethod sleep 2>../out || cat ../out $ hg --profile --config profiling.statformat=bymethod sleep 2>../out || cat ../out
$ head -n 1 ../out $ head -n 1 ../out
% cumulative self % cumulative self
$ cat ../out | statprofran $ cat ../out | statprofran
$ hg --profile --config profiling.statformat=hotpath sleep 2>../out || cat ../out Windows real time tracking is broken, only use CPU
#if no-windows
$ hg --profile --config profiling.time-track=real --config profiling.statformat=hotpath sleep 2>../out || cat ../out
$ cat ../out | statprofran
$ grep sleepext_with_a_long_filename.py ../out | head -n 1
.* [0-9.]+% [0-9.]+s sleepext_with_a_long_filename.py:\s*sleep_for_at_least_one_stat_cycle, line \d+:\s+(while|pass).* (re)
#endif
$ hg --profile --config profiling.time-track=cpu --config profiling.statformat=hotpath sleep 2>../out || cat ../out
$ cat ../out | statprofran $ cat ../out | statprofran
$ grep sleepext_with_a_long_filename.py ../out $ grep sleepext_with_a_long_filename.py ../out | head -n 1
.* [0-9.]+% [0-9.]+s sleepext_with_a_long_filename.py:\s*sleep_for_at_least_one_stat_cycle, line 7: time\.sleep.* (re) .* [0-9.]+% [0-9.]+s sleepext_with_a_long_filename.py:\s*sleep_for_at_least_one_stat_cycle, line \d+:\s+(while|pass).* (re)
$ hg --profile --config profiling.statformat=json sleep 2>../out || cat ../out $ hg --profile --config profiling.statformat=json sleep 2>../out || cat ../out
$ cat ../out $ cat ../out
\[\[-?\d+.* (re) \[\[-?\d+.* (re)
statprof can be used as a standalone module statprof can be used as a standalone module
$ "$PYTHON" -m mercurial.statprof hotpath $ "$PYTHON" -m mercurial.statprof hotpath