Page MenuHomePhabricator

run-test: rework the redirection script for python on windows
ClosedPublic

Authored by marmoute on Jul 11 2021, 5:37 PM.

Details

Summary

This should get use something something overall simpler and clearer. Especially,
we now have a python.exe script (even if by default Windows has
C:\Python27\python.exe hardcoded in the register to open .py file)

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jul 11 2021, 5:37 PM
mharbison72 added inline comments.
tests/run-tests.py
3609–3616

Can you take a look at this line and the commit comment? I was confused by the commit comment because it mentions the file association stuff on Windows (I'm pretty sure we tried to avoid that), and this line talks about not using a symlink, but I didn't see that before.

marmoute added inline comments.Jul 11 2021, 8:30 PM
tests/run-tests.py
3609–3616

The symlinks we are making a reference to are in the first if block. Nothing to do with the previous state of the code before this commit. This is a reference to other code in the file.

marmoute updated this revision to Diff 29234.Jul 13 2021, 2:29 PM
Alphare added inline comments.
tests/run-tests.py
3630

This probably won't work with the CI now that we don't install the py executable anymore on Windows.

marmoute added inline comments.Jul 15 2021, 9:35 AM
tests/run-tests.py
3630

Which is fine, because we do not run the Windows CI with Python2. We only do Python3 run.

Alphare accepted this revision.Jul 15 2021, 9:36 AM
Alphare added inline comments.
tests/run-tests.py
3630

Yes, I thought it was worth mentioning

This revision is now accepted and ready to land.Jul 15 2021, 9:36 AM