Page MenuHomePhabricator

run-tests: introduce a `HGTEST_REAL_HG` variable for test
ClosedPublic

Authored by marmoute on Jul 9 2021, 8:35 PM.

Details

Summary

It turns out that currently, hg and which hg can point to different things
because hg is an alias… This is annoying because script and pieces of test
are unknowingly using the wrong hg.

We will fix it in another changeset. However some test actually need to use a
real hg binary and not some chg or rhg equivalent. So we introduce a new
variable with the right value and we put it to us in the appropriate location.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jul 9 2021, 8:35 PM
baymax updated this revision to Diff 29084.Jul 9 2021, 9:21 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 29104.Jul 9 2021, 11:41 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute edited the summary of this revision. (Show Details)Jul 10 2021, 1:47 PM
marmoute updated this revision to Diff 29136.
mharbison72 added inline comments.
tests/run-tests.py
3164

Do we even need the assertion? When I passed None in as args, it raised an error.

Alphare added inline comments.
tests/run-tests.py
3164

What would you expect to happen by passing None?

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.