This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11052

tests: blacklist a handful of test with `rhg` or `chg`
ClosedPublic

Authored by marmoute on Jul 9 2021, 8:35 PM.

Download Raw Diff

Details

Reviewers

Alphare

Group Reviewers

hg-reviewers

Commits

rHGbe496e3489b9: tests: blacklist a handful of test with `rhg` or `chg`
rHGc5e5937e64da: tests: blacklist a handful of test with `rhg` or `chg`

Summary

The use of alias to enforce chg and rhg means we are actually using a mix
of rhg/chg and hg when calling hg in the test. Fixing this breaks
various tests. This would be a large detour to fix that. I am disabling
them for now with an appropriate comment.

We would hopefully get back to them by the 5.8 release.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jul 9 2021, 8:35 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptJul 9 2021, 8:35 PM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

marmoute added a child revision: D11053: run-tests: rely on an actual executable in PATH instead of alias for `hg`.Jul 9 2021, 8:35 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute edited the summary of this revision. (Show Details)Jul 10 2021, 1:47 PM

You probably mean 5.9, right?

Cool that we're finding out these bugs before they bite us too hard. This will also be important to fix during the freeze.

This revision is now accepted and ready to land.Jul 13 2021, 12:03 PM

marmoute added a commit: rHGc5e5937e64da: tests: blacklist a handful of test with `rhg` or `chg`.Jul 13 2021, 12:27 PM

Closed by commit rHGc5e5937e64da: tests: blacklist a handful of test with `rhg` or `chg` (authored by marmoute). · Explain Why

This revision was automatically updated to reflect the committed changes.

marmoute added a commit: rHGbe496e3489b9: tests: blacklist a handful of test with `rhg` or `chg`.Jul 13 2021, 2:18 PM

Alphare added inline comments.Jul 23 2021, 8:30 AM

tests/test-commandserver.t
1	I can reproduce the hang with `rhg` for this test.
tests/test-nointerrupt.t
1	I cannot reproduce the hang with `rhg` for this test however
tests/test-ssh-repoerror.t
1	This test doesn't hang either, but all permission-related errors have different output (even though the behavior is the same)

I’ve reproduced the same as Alphare.

The test-commandserver.t hang happens in the first chunk of inline Python code with the earlycrasher.py extension. I see two python3 /home/simon/projects/hg/hg serve --cmdserver unix -a .hg/server.sock processes that both appear to be waiting for socket-related events.

test-ssh-repoerror.t had some "repo not found" errors instead of permission errors. I’ve submitted D11230 to fix that, though the test still fails with rhg since the formatting of permission errors is slightly different.

Revision Contents
Changeset List

			Path	Packages
M			tests/test-commandserver.t (10 lines)
M			tests/test-infinitepush-bundlestore.t (9 lines)
M			tests/test-infinitepush.t (7 lines)
M			tests/test-nointerrupt.t (6 lines)
M			tests/test-ssh-repoerror.t (6 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	29066		Jul 9 2021, 8:35 PM	★	★
Diff 2	29087		Jul 9 2021, 9:21 PM	★	★
Diff 3	29107		Jul 9 2021, 11:41 PM	★	★
Diff 4	29225	rHGc5e5937e64dac87bdf51910e81ac5fea3188f326	Jul 9 2021, 2:42 PM	★	★

Status	Author	Revision
Closed	Alphare	D11004 test-run-tests: add missing backslash for Windows
Closed	Alphare	D11003 windows: use cpu-intensive task instead of real time in test
Closed	Alphare	D11002 windows: use shell function instead of variable substitution
Closed	marmoute	D11041 run-tests: use a global WINDOWS constant instead of multiple tests
Closed	marmoute	D11034 test-run-test: use explicit variables to clarify paths
Closed	marmoute	D11087 sigpipe-remote: simply delegate pipe forwarding to subprocess we can kill
Closed	marmoute	D11086 sigpipe-remote: verify the script is IO are unbuffered
Closed	marmoute	D11085 sigpipe-remote: check environment variable sooner
Closed	marmoute	D11084 test-sigpipe: run the hook using `sh`
Closed	marmoute	D11083 dummyssh: call python script with python
Closed	marmoute	D11082 dummyssh: use subprocess instead of os.call
Closed	marmoute	D11081 run-test: rework the redirection script for python on windows
Closed	marmoute	D11080 run-test: act that we requires MSYS to run the test on Windows
Closed	marmoute	D11079 sigpipe-remote: display more information about the non-py3 python
Closed	marmoute	D11078 sigpipe-remote: check for python version earlier in the script
Closed	marmoute	D11045 run-tests: cleanup windows generation of the python / python3 pointeur
Closed	marmoute	D11044 run-tests: always define a custom-bin directory
Closed	marmoute	D11043 run-tests: explicitly track that `pythondir` was inferred
Closed	Alphare	D11025 ci-windows: introduce manual windows CI
Closed	marmoute	D11073 windows: make sure we fully read and cleany close the connection
Closed	marmoute	D11048 test-infinitepush: drop unused helper
Closed	marmoute	D11047 run-tests: setup "correct" python earlier
Abandoned	marmoute	D11057 compat: enforce upper case drive letter in mercurial too
Closed	marmoute	D11056 test-bookmark: clarify the path involved in a pull creating divergence
Closed	marmoute	D11055 test-removeemptydirs: adjust to Windows behavior for the `histedit` case
Closed	marmoute	D11054 test-removeemptydirs: clarify the state of things in the `histedit` case
Closed	marmoute	D11053 run-tests: rely on an actual executable in PATH instead of alias for `hg`
Closed	marmoute	D11052 tests: blacklist a handful of test with `rhg` or `chg`
Closed	marmoute	D11051 run-tests: use more explicit signaling for `chg`
Closed	marmoute	D11050 run-tests: drop the `rhg` flag for `hghave.py` if unset
Closed	marmoute	D11049 run-tests: introduce a `HGTEST_REAL_HG` variable for test
Closed	marmoute	D11046 run-test: clarify the error with a bad --with-hg is passed
Closed	marmoute	D11072 check-code: add a rules to catch os.path.abspath
Closed	marmoute	D11071 windows: use abspath in convert.subversion
Closed	marmoute	D11070 windows: use abspath in convert.git
Closed	marmoute	D11069 windows: use abspath in convert.bzr
Closed	marmoute	D11068 windows: use abspath in the git extension
Closed	marmoute	D11067 windows: use abspath in url
Closed	marmoute	D11066 windows: use abspath in subrepoutil
Closed	marmoute	D11065 windows: use abspath in subrepo
Closed	marmoute	D11064 windows: use abspath in hgwebdir
Closed	marmoute	D11063 windows: use abspath in mercurial/hg.py
Closed	marmoute	D11062 windows: use abspath in extensions
Closed	marmoute	D11061 windows: use abspath in commandserver
Closed	marmoute	D11060 windows: use abspath in chgserver
Closed	marmoute	D11059 windows: introduce a `util.abspath` to replace os.path.abspath
Closed	marmoute	D11058 windows: enforce upper case drive letter for getcwd in mercurial too
Closed	marmoute	D11042 hg-ssh: normalize the drive of the current working directory on windows
Closed	marmoute	D11035 run-tests: enforce the drive letter from `getcwd` to upper case
Closed	Alphare	D11000 windows: add windows behavior on broken pager
Closed	Alphare	D11001 run-tests: also catch double-escapes for $TESTTMP

Diff 29225

tests/test-commandserver.t

				#require no-rhg no-chg
				AlphareUnsubmitted Not Done I can reproduce the hang with `rhg` for this test. Alphare: I can reproduce the hang with `rhg` for this test.

				XXX-RHG this test hangs if `hg` is really `rhg`. This was hidden by the use of
				`alias hg=rhg` by run-tests.py. With such alias removed, this test is revealed
				buggy. This need to be resolved sooner than later.

				XXX-CHG this test hangs if `hg` is really `chg`. This was hidden by the use of
				`alias hg=chg` by run-tests.py. With such alias removed, this test is revealed
				buggy. This need to be resolved sooner than later.

	#if windows			#if windows
	$ PYTHONPATH="$TESTDIR/../contrib;$PYTHONPATH"			$ PYTHONPATH="$TESTDIR/../contrib;$PYTHONPATH"
	#else			#else
	$ PYTHONPATH="$TESTDIR/../contrib:$PYTHONPATH"			$ PYTHONPATH="$TESTDIR/../contrib:$PYTHONPATH"
	#endif			#endif
	$ export PYTHONPATH			$ export PYTHONPATH

	typical client does not want echo-back messages, so test without it:			typical client does not want echo-back messages, so test without it:

tests/test-infinitepush-bundlestore.t

	#require no-reposimplestore			#require no-reposimplestore no-chg

				XXX-CHG this test hangs if `hg` is really `chg`. This was hidden by the use of
				`alias hg=chg` by run-tests.py. With such alias removed, this test is revealed
				buggy. This need to be resolved sooner than later.


				Testing infinipush extension and the confi options provided by it

	Create an ondisk bundlestore in .hg/scratchbranches			Create an ondisk bundlestore in .hg/scratchbranches
	$ . "$TESTDIR/library-infinitepush.sh"			$ . "$TESTDIR/library-infinitepush.sh"
	$ cp $HGRCPATH $TESTTMP/defaulthgrc			$ cp $HGRCPATH $TESTTMP/defaulthgrc
	$ setupcommon			$ setupcommon
	$ mkcommit() {			$ mkcommit() {
	> echo "$1" > "$1"			> echo "$1" > "$1"
	> hg add "$1"			> hg add "$1"

tests/test-infinitepush.t

	#require no-reposimplestore			#require no-reposimplestore no-chg

				XXX-CHG this test hangs if `hg` is really `chg`. This was hidden by the use of
				`alias hg=chg` by run-tests.py. With such alias removed, this test is revealed
				buggy. This need to be resolved sooner than later.


	Testing infinipush extension and the confi options provided by it			Testing infinipush extension and the confi options provided by it

	Setup			Setup

	$ . "$TESTDIR/library-infinitepush.sh"			$ . "$TESTDIR/library-infinitepush.sh"
	$ cp $HGRCPATH $TESTTMP/defaulthgrc			$ cp $HGRCPATH $TESTTMP/defaulthgrc
	$ setupcommon			$ setupcommon

tests/test-nointerrupt.t

	#require no-windows			#require no-windows no-rhg
				AlphareUnsubmitted Not Done I cannot reproduce the hang with `rhg` for this test however Alphare: I cannot reproduce the hang with `rhg` for this test however

				XXX-RHG this test hangs if `hg` is really `rhg`. This was hidden by the use of
				`alias hg=rhg` by run-tests.py. With such alias removed, this test is revealed
				buggy. This need to be resolved sooner than later.

	Dummy extension simulating unsafe long running command			Dummy extension simulating unsafe long running command
	$ cat > sleepext.py <<EOF			$ cat > sleepext.py <<EOF
	> import itertools			> import itertools
	> import time			> import time
	>			>
	> from mercurial.i18n import _			> from mercurial.i18n import _
	> from mercurial import registrar			> from mercurial import registrar

tests/test-ssh-repoerror.t

	#require unix-permissions no-root			#require unix-permissions no-root no-windows no-rhg
				AlphareUnsubmitted Not Done This test doesn't hang either, but all permission-related errors have different output (even though the behavior is the same) Alphare: This test doesn't hang either, but all permission-related errors have different output (even…

				XXX-RHG this test hangs if `hg` is really `rhg`. This was hidden by the use of
				`alias hg=rhg` by run-tests.py. With such alias removed, this test is revealed
				buggy. This need to be resolved sooner than later.

	initial setup			initial setup

	$ cat << EOF >> $HGRCPATH			$ cat << EOF >> $HGRCPATH
	> [ui]			> [ui]
	> ssh="$PYTHON" "$TESTDIR/dummyssh"			> ssh="$PYTHON" "$TESTDIR/dummyssh"
	> EOF			> EOF