tests/test-run-tests.t
26	yes, but this is the value that Mecurial is working with. The symlink got resolve and the executable is seen as `true. I don't think the output is confusing. I think the check is confusing.

marmoute updated this revision to Diff 29201.

Alphare added a subscriber: Alphare.

Alphare added inline comments.

tests/test-run-tests.t
26	Agreed, this is what the test is testing, so this output is strictly better IMO

This revision was not accepted when it landed; it landed in state Needs Review.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			tests/run-tests.py (4 lines)
M			tests/test-run-tests.t (2 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	29060		Jul 9 2021, 8:34 PM	★	★
Diff 2	29081		Jul 9 2021, 9:21 PM	★	★
Diff 3	29101		Jul 9 2021, 11:41 PM	★	★
Diff 4	29134		Jul 10 2021, 1:46 PM	★	★
Diff 5	29201		Jul 11 2021, 11:54 PM	★	★
Diff 6	29221	rHG05abe1ff1edd66521f8966731d3a99ea4f38af78	Jul 9 2021, 11:06 AM	★	★

	if options.with_hg:			if options.with_hg:
	options.with_hg = canonpath(_sys2bytes(options.with_hg))			options.with_hg = canonpath(_sys2bytes(options.with_hg))
	if not (			if not (
	os.path.isfile(options.with_hg)			os.path.isfile(options.with_hg)
	and os.access(options.with_hg, os.X_OK)			and os.access(options.with_hg, os.X_OK)
	):			):
	parser.error('--with-hg must specify an executable hg script')			parser.error('--with-hg must specify an executable hg script')
	if os.path.basename(options.with_hg) not in [b'hg', b'hg.exe']:			if os.path.basename(options.with_hg) not in [b'hg', b'hg.exe']:
	sys.stderr.write('warning: --with-hg should specify an hg script\n')			msg = 'warning: --with-hg should specify an hg script, not: %s\n'
				msg %= _bytes2sys(os.path.basename(options.with_hg))
				sys.stderr.write(msg)
	sys.stderr.flush()			sys.stderr.flush()

	if (options.chg or options.with_chg) and WINDOWS:			if (options.chg or options.with_chg) and WINDOWS:
	parser.error('chg does not work on %s' % os.name)			parser.error('chg does not work on %s' % os.name)
	if (options.rhg or options.with_rhg) and WINDOWS:			if (options.rhg or options.with_rhg) and WINDOWS:
	parser.error('rhg does not work on %s' % os.name)			parser.error('rhg does not work on %s' % os.name)
	if options.with_chg:			if options.with_chg:
	options.chg = False # no installation to temporary location			options.chg = False # no installation to temporary location

	> "$PYTHON" $TESTDIR/run-tests.py --with-hg=`which hg` -j1 "$@"			> "$PYTHON" $TESTDIR/run-tests.py --with-hg=`which hg` -j1 "$@"
	> }			> }

	error paths			error paths

	#if symlink			#if symlink
	$ ln -s `which true` hg			$ ln -s `which true` hg
	$ "$PYTHON" $TESTDIR/run-tests.py --with-hg=./hg			$ "$PYTHON" $TESTDIR/run-tests.py --with-hg=./hg
	warning: --with-hg should specify an hg script			warning: --with-hg should specify an hg script, not: true
				mharbison72Unsubmitted Not Done This message seems more confusing to me, since it wasn't specified with `true`. mharbison72: This message seems more confusing to me, since it wasn't specified with `true`.
				marmouteAuthorUnsubmitted Done yes, but this is the value that Mecurial is working with. The symlink got resolve and the executable is seen as `true. I don't think the output is confusing. I think the check is confusing. marmoute: yes, but this is the value that Mecurial is working with. The symlink got resolve and the…
				AlphareUnsubmitted Not Done Agreed, this is what the test is testing, so this output is strictly better IMO Alphare: Agreed, this is what the test is testing, so this output is strictly better IMO
	running 0 tests using 0 parallel processes			running 0 tests using 0 parallel processes

	# Ran 0 tests, 0 skipped, 0 failed.			# Ran 0 tests, 0 skipped, 0 failed.
	$ rm hg			$ rm hg
	#endif			#endif

	#if execbit			#if execbit
	$ touch hg			$ touch hg

This is an archive of the discontinued Mercurial Phabricator instance.

run-test: clarify the error with a bad --with-hg is passed
ClosedPublic