Page MenuHomePhabricator

run-test: clarify the error with a bad --with-hg is passed
ClosedPublic

Authored by marmoute on Jul 9 2021, 8:34 PM.

Details

Summary

This helped me to understand what was going on when I got into trouble.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jul 9 2021, 8:34 PM
baymax updated this revision to Diff 29081.Jul 9 2021, 9:21 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 29101.Jul 9 2021, 11:41 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute edited the summary of this revision. (Show Details)Jul 10 2021, 1:46 PM
marmoute updated this revision to Diff 29134.
mharbison72 requested changes to this revision.Jul 11 2021, 7:29 PM
mharbison72 added a subscriber: mharbison72.
mharbison72 added inline comments.
tests/test-run-tests.t
26

This message seems more confusing to me, since it wasn't specified with true.

This revision now requires changes to proceed.Jul 11 2021, 7:29 PM
marmoute added inline comments.Jul 11 2021, 7:47 PM
tests/test-run-tests.t
26

yes, but this is the value that Mecurial is working with. The symlink got resolve and the executable is seen as `true.

I don't think the output is confusing. I think the check is confusing.

Alphare accepted this revision.Jul 13 2021, 11:46 AM
Alphare added a subscriber: Alphare.
Alphare added inline comments.
tests/test-run-tests.t
26

Agreed, this is what the test is testing, so this output is strictly better IMO

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.