This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11084

test-sigpipe: run the hook using `sh`
ClosedPublic

Authored by marmoute on Jul 11 2021, 11:05 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGa8d1adeeba87: test-sigpipe: run the hook using `sh`
Summary

This make the hook properly run on Windows.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jul 11 2021, 11:05 PM
Alphare added a subscriber: Alphare.Jul 13 2021, 12:25 PM

I thought this didn't work on other platforms than Windows?

marmoute added a comment.Jul 15 2021, 9:04 AM
In D11084#169813, @Alphare wrote:

I thought this didn't work on other platforms than Windows?

The test does not work (yet, see the rest of the series), but at least now the hooks can properly run on windows.

marmoute added a commit: rHGa8d1adeeba87: test-sigpipe: run the hook using `sh`.Jul 16 2021, 1:04 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGa8d1adeeba87: test-sigpipe: run the hook using `sh` (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 29298

tests/test-transaction-rollback-on-sigpipe.t

$ remotecmd="$RUNTESTDIR/testlib/sigpipe-remote.py" $ remotecmd="$RUNTESTDIR/testlib/sigpipe-remote.py"
In the pretxnchangegroup hook, kill the PIDs recorded above to simulate ssh In the pretxnchangegroup hook, kill the PIDs recorded above to simulate ssh
disconnecting. Then exit nonzero, to force a transaction rollback. disconnecting. Then exit nonzero, to force a transaction rollback.
$ cat >remote/.hg/hgrc <<EOF $ cat >remote/.hg/hgrc <<EOF
> [hooks] > [hooks]
> pretxnchangegroup.00-break-things="$RUNTESTDIR/testlib/wait-on-file" 10 "$SYNCFILE2" "$SYNCFILE1" > pretxnchangegroup.00-break-things=sh "$RUNTESTDIR/testlib/wait-on-file" 10 "$SYNCFILE2" "$SYNCFILE1"
> pretxnchangegroup.01-output-things=echo "some remote output to be forward to the closed pipe" > pretxnchangegroup.01-output-things=echo "some remote output to be forward to the closed pipe"
> EOF > EOF
$ hg --cwd ./remote tip -T '{node|short}\n' $ hg --cwd ./remote tip -T '{node|short}\n'
000000000000 000000000000
$ cd local $ cd local
$ echo foo > foo ; hg commit -qAm "commit" $ echo foo > foo ; hg commit -qAm "commit"
$ hg push -e "\"$PYTHON\" \"$TESTDIR/dummyssh\"" --remotecmd "$remotecmd" $ hg push -e "\"$PYTHON\" \"$TESTDIR/dummyssh\"" --remotecmd "$remotecmd"