Page MenuHomePhabricator

run-tests: rely on an actual executable in PATH instead of alias for `hg`
ClosedPublic

Authored by marmoute on Jul 9 2021, 8:35 PM.

Details

Summary

The alias approach is poorly inherited by other process that the test might
spawn.

To solve this we use the same approach as for python/python3 we write an
executable file explicitly. Doing this fixes which hg invocation that now
returns the same location as hg.

Using chg server side has some minor effect on some stdout/stderr ordering when
using chg as the server too.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jul 9 2021, 8:35 PM
baymax updated this revision to Diff 29088.Jul 9 2021, 9:22 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 29108.Jul 9 2021, 11:41 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute retitled this revision from run-tests: rely on an actual file in PATH instead of alias for `hg` to run-tests: rely on an actual executable in PATH instead of alias for `hg`.Jul 10 2021, 1:47 PM
marmoute edited the summary of this revision. (Show Details)
marmoute updated this revision to Diff 29139.
Alphare accepted this revision.Jul 13 2021, 12:09 PM
Alphare added a subscriber: Alphare.
Alphare added inline comments.
tests/test-bundle2-exchange.t
754

ew

This revision is now accepted and ready to land.Jul 13 2021, 12:09 PM