This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11110

largefile: use `set_untracked` in the `forget` override
ClosedPublic

Authored by marmoute on Jul 18 2021, 5:53 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG2af9709ea13c: largefile: use `set_untracked` in the `forget` override
Summary

This is the new shinny API.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Jul 18 2021, 5:53 PM
pulkit accepted this revision.Jul 18 2021, 6:36 PM
This revision is now accepted and ready to land.Jul 18 2021, 6:36 PM
marmoute updated this revision to Diff 29378.Jul 19 2021, 3:31 AM
marmoute added a commit: rHG2af9709ea13c: largefile: use `set_untracked` in the `forget` override.Jul 19 2021, 9:16 AM
Closed by commit rHG2af9709ea13c: largefile: use `set_untracked` in the `forget` override (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.
marmoute updated this revision to Diff 29469.Jul 19 2021, 10:50 AM

Revision Contents
Changeset List

PathPackages
Mhgext/largefiles/overrides.py (5 lines)

Diff 29469

hgext/largefiles/overrides.py

if ui.verbose or not m.exact(f): if ui.verbose or not m.exact(f):
ui.status(_(b'removing %s\n') % uipathfn(f)) ui.status(_(b'removing %s\n') % uipathfn(f))
# Need to lock because standin files are deleted then removed from the # Need to lock because standin files are deleted then removed from the
# repository and we could race in-between. # repository and we could race in-between.
with repo.wlock(): with repo.wlock():
lfdirstate = lfutil.openlfdirstate(ui, repo) lfdirstate = lfutil.openlfdirstate(ui, repo)
for f in forget: for f in forget:
if lfdirstate[f] == b'a': lfdirstate.set_untracked(f)
lfdirstate.drop(f)
else:
lfdirstate.remove(f)
lfdirstate.write() lfdirstate.write()
standins = [lfutil.standin(f) for f in forget] standins = [lfutil.standin(f) for f in forget]
for f in standins: for f in standins:
repo.wvfs.unlinkpath(f, ignoremissing=True) repo.wvfs.unlinkpath(f, ignoremissing=True)
rejected = repo[None].forget(standins) rejected = repo[None].forget(standins)
bad.extend(f for f in rejected if f in m.files()) bad.extend(f for f in rejected if f in m.files())
forgot.extend(f for f in forget if f not in rejected) forgot.extend(f for f in forget if f not in rejected)