Page MenuHomePhabricator

dirstate: deprecate `dirstate.remove` in all cases
ClosedPublic

Authored by marmoute on Jul 19 2021, 6:41 AM.

Details

Summary

This will make sure that code will use the newer, more semantic API sooner than
later.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jul 19 2021, 6:41 AM
Alphare added inline comments.
mercurial/dirstate.py
772

Shouldn't that be 6.0?

Alphare added inline comments.Jul 19 2021, 10:41 AM
mercurial/dirstate.py
772

Seems like this was lost and then found again in D11183

marmoute added inline comments.Jul 19 2021, 10:43 AM
mercurial/dirstate.py
772

It should

marmoute updated this revision to Diff 29472.Jul 19 2021, 10:52 AM
baymax updated this revision to Diff 29500.Jul 19 2021, 11:47 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.Jul 19 2021, 12:28 PM
This revision is now accepted and ready to land.Jul 19 2021, 12:28 PM
baymax updated this revision to Diff 29506.Jul 19 2021, 3:52 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit accepted this revision.Jul 20 2021, 3:32 PM
This revision was automatically updated to reflect the committed changes.