Page MenuHomePhabricator

mq: use `update_file_p1` instead of `remove` when adjusting dirstate
ClosedPublic

Authored by marmoute on Jul 19 2021, 6:41 AM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jul 19 2021, 6:41 AM

Shouldn't that be p1_tracked=True, wc_tracked=False?

Shouldn't that be p1_tracked=True, wc_tracked=False?

No, because update_file_p1 is not taking a wc_tracked parameter it just preserve the existing one. (which is already untracked here)

Shouldn't that be p1_tracked=True, wc_tracked=False?

No, because update_file_p1 is not taking a wc_tracked parameter it just preserve the existing one. (which is already untracked here)

Right!

Alphare accepted this revision.Jul 19 2021, 12:28 PM
This revision is now accepted and ready to land.Jul 19 2021, 12:28 PM
baymax updated this revision to Diff 29502.Jul 19 2021, 3:52 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit accepted this revision.Jul 20 2021, 3:31 PM