Page MenuHomePhabricator

record: use `update_file` instead of `normallookup`
ClosedPublic

Authored by marmoute on Jul 19 2021, 10:09 AM.

Details

Summary

We are cheating a bit to enforce we are in a pending change context. This will
have to be cleaned up later.

The end goal is reached, we are now using the newer, more semantic API.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jul 19 2021, 10:09 AM
Alphare added inline comments.
mercurial/dirstate.py
510 ↗(On Diff #29450)

This seems unrelated?

marmoute added inline comments.Jul 19 2021, 10:42 AM
mercurial/dirstate.py
510 ↗(On Diff #29450)

This is the remain of some older draft that is clinging to life, it should be dropped. (update coming)

marmoute updated this revision to Diff 29476.Jul 19 2021, 10:54 AM
Alphare accepted this revision.Jul 19 2021, 12:28 PM
This revision is now accepted and ready to land.Jul 19 2021, 12:28 PM
baymax updated this revision to Diff 29517.Jul 19 2021, 4:04 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit accepted this revision.Jul 20 2021, 3:45 PM
This revision was automatically updated to reflect the committed changes.