This is an archive of the discontinued Mercurial Phabricator instance.

largefile: use `set_possibly_dirty` instead of `normallookup`

Authored by marmoute on Jul 19 2021, 10:08 AM.

Diff Detail

rHG Mercurial
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jul 19 2021, 10:08 AM
Alphare accepted this revision.Jul 19 2021, 12:28 PM
This revision is now accepted and ready to land.Jul 19 2021, 12:28 PM
baymax updated this revision to Diff 29508.Jul 19 2021, 4:03 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit accepted this revision.Jul 20 2021, 3:39 PM
mharbison72 added inline comments.

Should this be a ProgrammingError, since the frozen apps on Windows and Mac disabled assertions? Or is there enough testing around all combinations that this is just for the tests to flag problems?