( )⚙ D11604 dirstate-item: replace call to new_possibly_dirty

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11604

dirstate-item: replace call to new_possibly_dirty
ClosedPublic

Authored by marmoute on Oct 3 2021, 6:53 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG898de425bcd6: dirstate-item: replace call to new_possibly_dirty
Summary

The constructor is on its way out, so we inline the last relevant call before
dropping it.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Oct 3 2021, 6:53 AM
Alphare accepted this revision.Oct 3 2021, 5:19 PM
This revision is now accepted and ready to land.Oct 3 2021, 5:19 PM
marmoute added a commit: rHG898de425bcd6: dirstate-item: replace call to new_possibly_dirty.Oct 3 2021, 5:37 PM
Closed by commit rHG898de425bcd6: dirstate-item: replace call to new_possibly_dirty (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30609

mercurial/pure/parsers.py

else: else:
p1_tracked = True p1_tracked = True
p2_info = False p2_info = False
return cls(p1_tracked=p1_tracked, p2_info=p2_info) return cls(p1_tracked=p1_tracked, p2_info=p2_info)
elif state == b'n': elif state == b'n':
if size == FROM_P2: if size == FROM_P2:
return cls(wc_tracked=True, p2_info=True) return cls(wc_tracked=True, p2_info=True)
elif size == NONNORMAL: elif size == NONNORMAL:
return cls.new_possibly_dirty() return cls(wc_tracked=True, p1_tracked=True)
elif mtime == AMBIGUOUS_TIME: elif mtime == AMBIGUOUS_TIME:
instance = cls.new_normal(mode, size, 42) instance = cls.new_normal(mode, size, 42)
instance._mtime = None instance._mtime = None
return instance return instance
else: else:
return cls.new_normal(mode, size, mtime) return cls.new_normal(mode, size, mtime)
else: else:
raise RuntimeError(b'unknown state: %s' % state) raise RuntimeError(b'unknown state: %s' % state)

rust/hg-core/src/dirstate/entry.rs

if size == SIZE_FROM_OTHER_PARENT { if size == SIZE_FROM_OTHER_PARENT {
Self { Self {
// might be missing P1_TRACKED // might be missing P1_TRACKED
flags: Flags::WDIR_TRACKED | Flags::P2_INFO, flags: Flags::WDIR_TRACKED | Flags::P2_INFO,
mode_size: None, mode_size: None,
mtime: None, mtime: None,
} }
} else if size == SIZE_NON_NORMAL { } else if size == SIZE_NON_NORMAL {
Self::new_possibly_dirty() Self {
flags: Flags::WDIR_TRACKED | Flags::P1_TRACKED,
mode_size: None,
mtime: None,
}
} else if mtime == MTIME_UNSET { } else if mtime == MTIME_UNSET {
Self { Self {
flags: Flags::WDIR_TRACKED | Flags::P1_TRACKED, flags: Flags::WDIR_TRACKED | Flags::P1_TRACKED,
mode_size: Some((mode, size)), mode_size: Some((mode, size)),
mtime: None, mtime: None,
} }
} else { } else {
Self::new_normal(mode, size, mtime) Self::new_normal(mode, size, mtime)