Differential D11701

dirstate: ignore sub-second component when either is zero in mtime
ClosedPublic
Actions

Authored by marmoute on Oct 19 2021, 6:03 PM.

Details

Reviewers

Alphare

Group Reviewers

hg-reviewers

Commits

rHG68bb472aee9c: dirstate: ignore sub-second component when either is zero in mtime

Summary

When comparing mtimes for equality.

Some APIs simply return zero when more precision is not available.
When comparing values from different sources, if only one is truncated in
that way, doing a simple comparison would cause many false negatives.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Oct 19 2021, 6:03 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptOct 19 2021, 6:03 PM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

marmoute added a child revision: D11702: dirstate-v2: actually use sub-second mtime precision.Oct 19 2021, 6:03 PM

Alphare accepted this revision.Oct 20 2021, 4:39 AM

This revision is now accepted and ready to land.Oct 20 2021, 4:39 AM

marmoute updated this revision to Diff 30932.Oct 20 2021, 5:12 AM

SimonSapin added a commit: rHG68bb472aee9c: dirstate: ignore sub-second component when either is zero in mtime.Oct 20 2021, 5:30 AM

Closed by commit rHG68bb472aee9c: dirstate: ignore sub-second component when either is zero in mtime (authored by SimonSapin). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			mercurial/cext/parsers.c (4 lines)
M			mercurial/dirstateutils/timestamp.py (26 lines)
M			mercurial/pure/parsers.py (4 lines)
M			rust/hg-core/src/dirstate/entry.rs (10 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	30919		Oct 19 2021, 6:03 PM	★	★
Diff 2	30932		Oct 20 2021, 5:12 AM	★	★
Diff 3	30943	rHG68bb472aee9c313e6d9542d48c09721d2c17d423	Oct 14 2021, 7:54 AM	★	★

Status	Author	Revision
Closed	marmoute	D11704 dirstate-v2: reorder flag to group related one together
Closed	marmoute	D11695 dirstate-v2: read the fallback value in Rust
Closed	marmoute	D11694 dirstate-v2: adjust the meaning of directory flags
Closed	marmoute	D11702 dirstate-v2: actually use sub-second mtime precision
Closed	marmoute	D11701 dirstate: ignore sub-second component when either is zero in mtime
Closed	marmoute	D11700 dirstate-v2: add a new MTIME_SECOND_AMBIGUOUS flags
Closed	SimonSapin	D11684 dirstate: store mtimes with nanosecond precision in memory
Closed	SimonSapin	D11696 rust: remove now-unused DirstateEntry::clear_ambiguous_mtime method
Closed	marmoute	D11699 dirstate: align Rust function name to `need_delay`
Closed	SimonSapin	D11691 dirstate: rename a `very_likely_equal` method to `likely_equal`