This is an archive of the discontinued Mercurial Phabricator instance.

config: track the "level" of a value
ClosedPublic

Authored by marmoute on Jan 29 2021, 8:40 PM.

Details

Summary

Config value now remember the "level" of the config that loaded it. This will be
used to ensure good priority management for alias.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Jan 29 2021, 8:40 PM
Alphare accepted this revision.Feb 8 2021, 5:19 AM
Alphare added a subscriber: Alphare.

This is a more "manual" implementation than the Rust one, but I suspect the churn would be too big and maybe the performance would be affected too much.

This is a more "manual" implementation than the Rust one, but I suspect the churn would be too big and maybe the performance would be affected too much.

Yeah, the goal of this series is mostly to add the new behavior with minimal internal change. That way we can introduce the new behavior (surprising) with associated test and clean up the config API to make the internal more insulated. Once this is done, it should be easier to refactor the internal if it seems useful.

baymax updated this revision to Diff 25518.Feb 9 2021, 6:29 PM

โœ… refresh by Heptapod after a successful CI run (๐Ÿ™ ๐Ÿ’š)

baymax updated this revision to Diff 25575.Feb 11 2021, 1:46 PM

โœ… refresh by Heptapod after a successful CI run (๐Ÿ™ ๐Ÿ’š)

pulkit accepted this revision.Mar 4 2021, 6:27 AM
This revision is now accepted and ready to land.Mar 4 2021, 6:27 AM
This revision was automatically updated to reflect the committed changes.