( )⚙ D10358 sidedata: add a way of replacing an existing sidedata computer

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10358

sidedata: add a way of replacing an existing sidedata computer
ClosedPublic

Authored by Alphare on Apr 10 2021, 3:14 PM.

Details

Reviewers
marmoute
Group Reviewers
hg-reviewers
Commits
rHG81eb7091c494: sidedata: add a way of replacing an existing sidedata computer
Summary

This will be useful in a future patch to replace a sequential computer with
a parallel computer. We only allow for explicit replacement, to force the users
to think about overriding computers.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare created this revision.Apr 10 2021, 3:14 PM
Alphare updated this revision to Diff 27035.Apr 19 2021, 6:10 AM
Alphare updated this revision to Diff 27101.Apr 20 2021, 9:39 AM
marmoute accepted this revision.Apr 22 2021, 1:49 PM
baymax updated this revision to Diff 27303.May 3 2021, 6:06 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 27453.May 3 2021, 9:01 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare added a commit: rHG81eb7091c494: sidedata: add a way of replacing an existing sidedata computer.May 5 2021, 6:42 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG81eb7091c494: sidedata: add a way of replacing an existing sidedata computer (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 27101

mercurial/interfaces/repository.py

pass pass
def debugwireargs(one, two, three=None, four=None, five=None): def debugwireargs(one, two, three=None, four=None, five=None):
pass pass
def savecommitmessage(text): def savecommitmessage(text):
pass pass
def register_sidedata_computer(kind, category, keys, computer, flags): def register_sidedata_computer(
kind, category, keys, computer, flags, replace=False
):
pass pass
def register_wanted_sidedata(category): def register_wanted_sidedata(category):
pass pass
class completelocalrepository( class completelocalrepository(
ilocalrepositorymain, ilocalrepositoryfilestorage ilocalrepositorymain, ilocalrepositoryfilestorage

mercurial/localrepo.py

return self.pathto(fp.name[len(self.root) + 1 :]) return self.pathto(fp.name[len(self.root) + 1 :])
def register_wanted_sidedata(self, category): def register_wanted_sidedata(self, category):
if requirementsmod.REVLOGV2_REQUIREMENT not in self.requirements: if requirementsmod.REVLOGV2_REQUIREMENT not in self.requirements:
# Only revlogv2 repos can want sidedata. # Only revlogv2 repos can want sidedata.
return return
self._wanted_sidedata.add(pycompat.bytestr(category)) self._wanted_sidedata.add(pycompat.bytestr(category))
def register_sidedata_computer(self, kind, category, keys, computer, flags): def register_sidedata_computer(
self, kind, category, keys, computer, flags, replace=False
):
if kind not in revlogconst.ALL_KINDS: if kind not in revlogconst.ALL_KINDS:
msg = _(b"unexpected revlog kind '%s'.") msg = _(b"unexpected revlog kind '%s'.")
raise error.ProgrammingError(msg % kind) raise error.ProgrammingError(msg % kind)
category = pycompat.bytestr(category) category = pycompat.bytestr(category)
if category in self._sidedata_computers.get(kind, []): already_registered = category in self._sidedata_computers.get(kind, [])
if already_registered and not replace:
msg = _( msg = _(
b"cannot register a sidedata computer twice for category '%s'." b"cannot register a sidedata computer twice for category '%s'."
) )
raise error.ProgrammingError(msg % category) raise error.ProgrammingError(msg % category)
if replace and not already_registered:
msg = _(
b"cannot replace a sidedata computer that isn't registered "
b"for category '%s'."
)
raise error.ProgrammingError(msg % category)
self._sidedata_computers.setdefault(kind, {}) self._sidedata_computers.setdefault(kind, {})
self._sidedata_computers[kind][category] = (keys, computer, flags) self._sidedata_computers[kind][category] = (keys, computer, flags)
# used to avoid circular references so destructors work # used to avoid circular references so destructors work
def aftertrans(files): def aftertrans(files):
renamefiles = [tuple(t) for t in files] renamefiles = [tuple(t) for t in files]