This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10401

urlutil: add a `get_clone_path` function
ClosedPublic

Authored by marmoute on Apr 14 2021, 7:37 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGebb13f9a9ba8: urlutil: add a `get_clone_path` function
Summary

We add a new function with a semantic focussed on clone operation (so without
an existing repository). I am not certain the return type is the best, but this
is what we need for now. Once all caller are migrated we might start thinking
about that the API should be. For now that will do.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Apr 14 2021, 7:37 PM
pulkit accepted this revision.Apr 15 2021, 7:46 AM
This revision is now accepted and ready to land.Apr 15 2021, 7:46 AM
marmoute added a commit: rHGebb13f9a9ba8: urlutil: add a `get_clone_path` function.Apr 15 2021, 9:45 AM
Closed by commit rHGebb13f9a9ba8: urlutil: add a `get_clone_path` function (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/hg.py (4 lines)
Mmercurial/utils/urlutil.py (7 lines)

Diff 26936

mercurial/hg.py

exclude in the repository copy, respectively. If not defined, all files exclude in the repository copy, respectively. If not defined, all files
will be included (a "full" clone). Otherwise a "narrow" clone containing will be included (a "full" clone). Otherwise a "narrow" clone containing
only the requested files will be performed. If ``storeincludepats`` is not only the requested files will be performed. If ``storeincludepats`` is not
defined but ``storeexcludepats`` is, ``storeincludepats`` is assumed to be defined but ``storeexcludepats`` is, ``storeincludepats`` is assumed to be
``path:.``. If both are empty sets, no files will be cloned. ``path:.``. If both are empty sets, no files will be cloned.
""" """
if isinstance(source, bytes): if isinstance(source, bytes):
origsource = ui.expandpath(source) src = urlutil.get_clone_path(ui, source, branch)
source, branches = urlutil.parseurl(origsource, branch) origsource, source, branches = src
srcpeer = peer(ui, peeropts, source) srcpeer = peer(ui, peeropts, source)
else: else:
srcpeer = source.peer() # in case we were called with a localrepo srcpeer = source.peer() # in case we were called with a localrepo
branches = (None, branch or []) branches = (None, branch or [])
origsource = source = srcpeer.url() origsource = source = srcpeer.url()
srclock = destlock = cleandir = None srclock = destlock = cleandir = None
destpeer = None destpeer = None
try: try:

mercurial/utils/urlutil.py

"""yields all the `(path, branch)` selected as pull source by `sources`""" """yields all the `(path, branch)` selected as pull source by `sources`"""
if not sources: if not sources:
sources = [b'default'] sources = [b'default']
for source in sources: for source in sources:
url = ui.expandpath(source) url = ui.expandpath(source)
yield parseurl(url, default_branches) yield parseurl(url, default_branches)
def get_clone_path(ui, source, default_branches=()):
"""return the `(origsource, path, branch)` selected as clone source"""
url = ui.expandpath(source)
path, branch = parseurl(url, default_branches)
return url, path, branch
def parseurl(path, branches=None): def parseurl(path, branches=None):
'''parse url#branch, returning (url, (branch, branches))''' '''parse url#branch, returning (url, (branch, branches))'''
u = url(path) u = url(path)
branch = None branch = None
if u.fragment: if u.fragment:
branch = u.fragment branch = u.fragment
u.fragment = None u.fragment = None
return bytes(u), (branch, branches or []) return bytes(u), (branch, branches or [])