This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10402

mq: use the new `get_clone_path` to get the remote url
ClosedPublic

Authored by marmoute on Apr 14 2021, 7:37 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGae4c0f279282: mq: use the new `get_clone_path` to get the remote url
Summary

We stop using ui.expandpath to use a function with a more defined semantic. This will help us to make it an option to point [paths] entry to multiple destination.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Apr 14 2021, 7:37 PM
pulkit accepted this revision.Apr 15 2021, 7:47 AM
This revision is now accepted and ready to land.Apr 15 2021, 7:47 AM
marmoute added a commit: rHGae4c0f279282: mq: use the new `get_clone_path` to get the remote url.Apr 15 2021, 9:45 AM
Closed by commit rHGae4c0f279282: mq: use the new `get_clone_path` to get the remote url (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/mq.py (5 lines)

Diff 26858

hgext/mq.py

url = repo.url() url = repo.url()
if url.endswith(b'/'): if url.endswith(b'/'):
url = url[:-1] url = url[:-1]
return url + b'/.hg/patches' return url + b'/.hg/patches'
# main repo (destination and sources) # main repo (destination and sources)
if dest is None: if dest is None:
dest = hg.defaultdest(source) dest = hg.defaultdest(source)
sr = hg.peer(ui, opts, ui.expandpath(source)) __, source_path, __ = urlutil.get_clone_path(ui, source)
sr = hg.peer(ui, opts, source_path)
# patches repo (source only) # patches repo (source only)
if opts.get(b'patches'): if opts.get(b'patches'):
patchespath = ui.expandpath(opts.get(b'patches')) __, patchespath, __ = urlutil.get_clone_path(ui, opts.get(b'patches'))
else: else:
patchespath = patchdir(sr) patchespath = patchdir(sr)
try: try:
hg.peer(ui, opts, patchespath) hg.peer(ui, opts, patchespath)
except error.RepoError: except error.RepoError:
raise error.Abort( raise error.Abort(
_(b'versioned patch repository not found (see init --mq)') _(b'versioned patch repository not found (see init --mq)')
) )