This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10405

patchbomb: use `get_unique_pull_path`
ClosedPublic

Authored by marmoute on Apr 14 2021, 7:37 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGa48f15f1c178: patchbomb: use `get_unique_pull_path`
Summary

The patchbomb code does not support multiple destinations yet. It would not be
too hard to implemented since hg outgoing does. However that is a bit too
much of a detour right now. In addition that kind of "select outgoing
changesets for processing" code exist for various commands so the best would be
to factor it out later.

Let us use the dedicated API until this is solved.

This comes with a small output change in the test that I find more accurate. So
I kept it.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Apr 14 2021, 7:37 PM
pulkit accepted this revision.Apr 15 2021, 7:48 AM
This revision is now accepted and ready to land.Apr 15 2021, 7:48 AM
marmoute added a commit: rHGa48f15f1c178: patchbomb: use `get_unique_pull_path`.Apr 15 2021, 9:46 AM
Closed by commit rHGa48f15f1c178: patchbomb: use `get_unique_pull_path` (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/patchbomb.py (6 lines)
Mtests/test-patchbomb.t (2 lines)

Diff 26940

hgext/patchbomb.py

msgs.append(msg) msgs.append(msg)
return msgs return msgs
def _getoutgoing(repo, dest, revs): def _getoutgoing(repo, dest, revs):
'''Return the revisions present locally but not in dest''' '''Return the revisions present locally but not in dest'''
ui = repo.ui ui = repo.ui
url = ui.expandpath(dest or b'default-push', dest or b'default') paths = urlutil.get_push_paths(repo, ui, [dest])
url = urlutil.parseurl(url)[0] safe_paths = [urlutil.hidepassword(p.rawloc) for p in paths]
ui.status(_(b'comparing with %s\n') % urlutil.hidepassword(url)) ui.status(_(b'comparing with %s\n') % b','.join(safe_paths))
revs = [r for r in revs if r >= 0] revs = [r for r in revs if r >= 0]
if not revs: if not revs:
revs = [repo.changelog.tiprev()] revs = [repo.changelog.tiprev()]
revs = repo.revs(b'outgoing(%s) and ::%ld', dest or b'', revs) revs = repo.revs(b'outgoing(%s) and ::%ld', dest or b'', revs)
if not revs: if not revs:
ui.status(_(b"no changes found\n")) ui.status(_(b"no changes found\n"))
return revs return revs

tests/test-patchbomb.t

Don't prompt for a CC header. Don't prompt for a CC header.
$ echo "[email]" >> $HGRCPATH $ echo "[email]" >> $HGRCPATH
$ echo "cc=" >> $HGRCPATH $ echo "cc=" >> $HGRCPATH
dest#branch URIs: dest#branch URIs:
$ hg email --date '1980-1-1 0:1' -n -t foo -s test -o ../t#test $ hg email --date '1980-1-1 0:1' -n -t foo -s test -o ../t#test
comparing with ../t comparing with ../t#test
From [test]: test From [test]: test
this patch series consists of 1 patches. this patch series consists of 1 patches.
displaying [PATCH] test ... displaying [PATCH] test ...
MIME-Version: 1.0 MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii" Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit Content-Transfer-Encoding: 7bit