This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10417

clone: use `get_clone_path`
ClosedPublic

Authored by marmoute on Apr 14 2021, 7:38 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG338ab1d89ddb: clone: use `get_clone_path`
Summary

"Surprisingly", the new API is well suited for hg clone too.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Apr 14 2021, 7:38 PM
pulkit added a subscriber: pulkit.Apr 15 2021, 11:15 AM

s/get_clone_path_usage/get_clone_path in commit message?

marmoute added a comment.Apr 16 2021, 4:49 AM
In D10417#158549, @pulkit wrote:

s/get_clone_path_usage/get_clone_path in commit message?

a yes. Thanks for spotting this.

marmoute retitled this revision from clone: use `get_clone_path_usage` to clone: use `get_clone_path`.Apr 16 2021, 4:52 AM
pulkit accepted this revision.Apr 17 2021, 4:51 PM
This revision is now accepted and ready to land.Apr 17 2021, 4:51 PM
marmoute added a commit: rHG338ab1d89ddb: clone: use `get_clone_path`.Apr 17 2021, 6:11 PM
Closed by commit rHG338ab1d89ddb: clone: use `get_clone_path` (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/hg.py (2 lines)

Diff 26873

mercurial/hg.py

try: try:
revs, checkout = addbranchrevs(srcpeer, srcpeer, branches, revs) revs, checkout = addbranchrevs(srcpeer, srcpeer, branches, revs)
if dest is None: if dest is None:
dest = defaultdest(source) dest = defaultdest(source)
if dest: if dest:
ui.status(_(b"destination directory: %s\n") % dest) ui.status(_(b"destination directory: %s\n") % dest)
else: else:
dest = ui.expandpath(dest) dest = urlutil.get_clone_path(ui, dest)[0]
dest = urlutil.urllocalpath(dest) dest = urlutil.urllocalpath(dest)
source = urlutil.urllocalpath(source) source = urlutil.urllocalpath(source)
if not dest: if not dest:
raise error.InputError(_(b"empty destination path is not valid")) raise error.InputError(_(b"empty destination path is not valid"))
destvfs = vfsmod.vfs(dest, expandpath=True) destvfs = vfsmod.vfs(dest, expandpath=True)