This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10425

profiling: use `util.expandpath` instead of `ui.expandpath` for output
ClosedPublic

Authored by marmoute on Apr 14 2021, 7:39 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG5a6a1cd21f09: profiling: use `util.expandpath` instead of `ui.expandpath` for output
Summary

Given we are talking about the path to an output file, I am fairly certain that
the initial author meant to expand ~ and the like and not to resolve entry
from [paths].

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

PathPackages
Mmercurial/profiling.py (2 lines)

Diff 26881

mercurial/profiling.py

profiler = b'stat' profiler = b'stat'
self._output = self._ui.config(b'profiling', b'output') self._output = self._ui.config(b'profiling', b'output')
try: try:
if self._output == b'blackbox': if self._output == b'blackbox':
self._fp = util.stringio() self._fp = util.stringio()
elif self._output: elif self._output:
path = self._ui.expandpath(self._output) path = util.expandpath(self._output)
self._fp = open(path, b'wb') self._fp = open(path, b'wb')
elif pycompat.iswindows: elif pycompat.iswindows:
# parse escape sequence by win32print() # parse escape sequence by win32print()
class uifp(object): class uifp(object):
def __init__(self, ui): def __init__(self, ui):
self._ui = ui self._ui = ui
def write(self, data): def write(self, data):