This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10615

sidedata: use revlogv2 requirement in the test helper
ClosedPublic

Authored by marmoute on May 3 2021, 7:53 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG8505d23928b1: sidedata: use revlogv2 requirement in the test helper
Summary

We are about to drop the requirement dedicated to sidedata (since revlogv2 will
support them unconditionally and previous version will not.).

To prepare this more we adapt the test code to not use that requirements.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.May 3 2021, 7:53 AM
baymax updated this revision to Diff 27530.May 3 2021, 9:44 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 27861.May 11 2021, 1:43 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 27987.May 17 2021, 7:02 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute added a commit: rHG8505d23928b1: sidedata: use revlogv2 requirement in the test helper.May 17 2021, 8:58 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG8505d23928b1: sidedata: use revlogv2 requirement in the test helper (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/testlib/ext-sidedata.py (2 lines)

Diff 28015

tests/testlib/ext-sidedata.py

return text, sd return text, sd
def wrapget_sidedata_helpers(orig, srcrepo, dstrepo): def wrapget_sidedata_helpers(orig, srcrepo, dstrepo):
repo, computers, removers = orig(srcrepo, dstrepo) repo, computers, removers = orig(srcrepo, dstrepo)
assert not computers and not removers # deal with composition later assert not computers and not removers # deal with composition later
addedreqs = dstrepo.requirements - srcrepo.requirements addedreqs = dstrepo.requirements - srcrepo.requirements
if requirements.SIDEDATA_REQUIREMENT in addedreqs: if requirements.REVLOGV2_REQUIREMENT in addedreqs:
def computer(repo, revlog, rev, old_sidedata): def computer(repo, revlog, rev, old_sidedata):
assert not old_sidedata # not supported yet assert not old_sidedata # not supported yet
update = {} update = {}
revlog.sidedatanocheck = True revlog.sidedatanocheck = True
try: try:
text = revlog.revision(rev) text = revlog.revision(rev)
finally: finally: