( )⚙ D10644 revlog: create a create `null_item` attribute for V0

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10644

revlog: create a create `null_item` attribute for V0
ClosedPublic

Authored by marmoute on May 4 2021, 10:14 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGba21cfd9b044: revlog: create a create `null_item` attribute for V0
Summary

This value is currently wrong, but at least it is now -obviously- wrong.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.May 4 2021, 10:14 AM
baymax updated this revision to Diff 27883.May 11 2021, 1:45 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.May 17 2021, 5:49 PM
This revision is now accepted and ready to land.May 17 2021, 5:49 PM
marmoute added a commit: rHGba21cfd9b044: revlog: create a create `null_item` attribute for V0.May 17 2021, 5:54 PM
Closed by commit rHGba21cfd9b044: revlog: create a create `null_item` attribute for V0 (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/revlogutils/revlogv0.py (3 lines)

Diff 27883

mercurial/revlogutils/revlogv0.py

def offset_type(offset, type): def offset_type(offset, type):
if (type & ~flagutil.REVIDX_KNOWN_FLAGS) != 0: if (type & ~flagutil.REVIDX_KNOWN_FLAGS) != 0:
raise ValueError(b'unknown revlog index flags') raise ValueError(b'unknown revlog index flags')
return int(int(offset) << 16 | type) return int(int(offset) << 16 | type)
class revlogoldindex(list): class revlogoldindex(list):
entry_size = INDEX_ENTRY_V0.size entry_size = INDEX_ENTRY_V0.size
null_item = (0, 0, 0, -1, -1, -1, -1, node.nullid)
@property @property
def nodemap(self): def nodemap(self):
msg = b"index.nodemap is deprecated, use index.[has_node|rev|get_rev]" msg = b"index.nodemap is deprecated, use index.[has_node|rev|get_rev]"
util.nouideprecwarn(msg, b'5.3', stacklevel=2) util.nouideprecwarn(msg, b'5.3', stacklevel=2)
return self._nodemap return self._nodemap
@util.propertycache @util.propertycache
del self._nodemap[self[r][7]] del self._nodemap[self[r][7]]
super(revlogoldindex, self).__delitem__(i) super(revlogoldindex, self).__delitem__(i)
def clearcaches(self): def clearcaches(self):
self.__dict__.pop('_nodemap', None) self.__dict__.pop('_nodemap', None)
def __getitem__(self, i): def __getitem__(self, i):
if i == -1: if i == -1:
return (0, 0, 0, -1, -1, -1, -1, node.nullid) return self.null_item
return list.__getitem__(self, i) return list.__getitem__(self, i)
def pack_header(self, header): def pack_header(self, header):
"""pack header information in binary""" """pack header information in binary"""
return b'' return b''
def entry_binary(self, rev): def entry_binary(self, rev):
"""return the raw binary string representing a revision""" """return the raw binary string representing a revision"""