( )⚙ D10958 dirstate-entry: `merged_removed` and `from_p2_removed` properties

This is an archive of the discontinued Mercurial Phabricator instance.

dirstate-entry: `merged_removed` and `from_p2_removed` properties
ClosedPublic

Authored by marmoute on Jul 4 2021, 5:50 PM.

Details

Summary

Lets start to define and use more semantic property. These two might be a bit
too low level and could be shaved off later, however this seems an improvement
for now.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jul 4 2021, 5:50 PM
SimonSapin accepted this revision.Jul 5 2021, 12:24 AM
pulkit added a subscriber: pulkit.Jul 6 2021, 12:31 PM
pulkit added inline comments.
mercurial/pure/parsers.py
107

This description does not sounds correct.

109

s/attraction/abstraction

110

missing closing brackets in comment

123

s/attraction/abstraction

124

missing closing brackets in comment

baymax updated this revision to Diff 28860.Jul 6 2021, 2:08 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit accepted this revision.Jul 6 2021, 2:50 PM
This revision is now accepted and ready to land.Jul 6 2021, 2:50 PM