( )⚙ D11002 windows: use shell function instead of variable substitution

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11002

windows: use shell function instead of variable substitution
ClosedPublic

Authored by Alphare on Jul 7 2021, 9:14 AM.

Details

Reviewers
marmoute
Group Reviewers
hg-reviewers
Commits
rHG17fde6763286: windows: use shell function instead of variable substitution
Summary

This makes it compatible with Windows

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Jul 7 2021, 9:14 AM
marmoute accepted this revision.Jul 7 2021, 11:57 AM
marmoute added a subscriber: marmoute.

okay Windows

Alphare added a commit: rHG17fde6763286: windows: use shell function instead of variable substitution.Jul 8 2021, 4:20 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG17fde6763286: windows: use shell function instead of variable substitution (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-profile.t (18 lines)

Diff 29027

tests/test-profile.t

$ hg st --prof 2>&1 | statprofran $ hg st --prof 2>&1 | statprofran
In alias In alias
$ hg --config "alias.profst=status --profile" profst 2>&1 | statprofran $ hg --config "alias.profst=status --profile" profst 2>&1 | statprofran
#if lsprof #if lsprof
$ prof='hg --config profiling.type=ls --profile' $ prof () {
> hg --config profiling.type=ls --profile $@
> }
$ $prof st 2>../out $ prof st 2>../out
$ grep CallCount ../out > /dev/null || cat ../out $ grep CallCount ../out > /dev/null || cat ../out
$ $prof --config profiling.output=../out st $ prof --config profiling.output=../out st
$ grep CallCount ../out > /dev/null || cat ../out $ grep CallCount ../out > /dev/null || cat ../out
$ $prof --config profiling.output=blackbox --config extensions.blackbox= st $ prof --config profiling.output=blackbox --config extensions.blackbox= st
$ grep CallCount .hg/blackbox.log > /dev/null || cat .hg/blackbox.log $ grep CallCount .hg/blackbox.log > /dev/null || cat .hg/blackbox.log
$ $prof --config profiling.format=text st 2>../out $ prof --config profiling.format=text st 2>../out
$ grep CallCount ../out > /dev/null || cat ../out $ grep CallCount ../out > /dev/null || cat ../out
$ echo "[profiling]" >> $HGRCPATH $ echo "[profiling]" >> $HGRCPATH
$ echo "format=kcachegrind" >> $HGRCPATH $ echo "format=kcachegrind" >> $HGRCPATH
$ $prof st 2>../out $ prof st 2>../out
$ grep 'events: Ticks' ../out > /dev/null || cat ../out $ grep 'events: Ticks' ../out > /dev/null || cat ../out
$ $prof --config profiling.output=../out st $ prof --config profiling.output=../out st
$ grep 'events: Ticks' ../out > /dev/null || cat ../out $ grep 'events: Ticks' ../out > /dev/null || cat ../out
#endif #endif
#if lsprof serve #if lsprof serve
Profiling of HTTP requests works Profiling of HTTP requests works
$ $prof --config profiling.format=text --config profiling.output=../profile.log serve -d -p $HGPORT --pid-file ../hg.pid -A ../access.log $ prof --config profiling.format=text --config profiling.output=../profile.log serve -d -p $HGPORT --pid-file ../hg.pid -A ../access.log
$ cat ../hg.pid >> $DAEMON_PIDS $ cat ../hg.pid >> $DAEMON_PIDS
$ hg -q clone -U http://localhost:$HGPORT ../clone $ hg -q clone -U http://localhost:$HGPORT ../clone
A single profile is logged because file logging doesn't append A single profile is logged because file logging doesn't append
$ grep CallCount ../profile.log | wc -l $ grep CallCount ../profile.log | wc -l
\s*1 (re) \s*1 (re)
#endif #endif