( )⚙ D11004 test-run-tests: add missing backslash for Windows

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11004

test-run-tests: add missing backslash for Windows
ClosedPublic

Authored by Alphare on Jul 7 2021, 9:14 AM.

Details

Reviewers
marmoute
Group Reviewers
hg-reviewers
Commits
rHG57bdecf4322c: test-run-tests: add missing backslash for Windows

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare created this revision.Jul 7 2021, 9:14 AM
marmoute accepted this revision.Jul 7 2021, 11:56 AM
Alphare added a commit: rHG57bdecf4322c: test-run-tests: add missing backslash for Windows.Jul 8 2021, 4:20 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG57bdecf4322c: test-run-tests: add missing backslash for Windows (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-run-tests.t (2 lines)

Diff 28937

tests/test-run-tests.t

running is placed. running is placed.
$ cat > test-runtestdir.t <<EOF $ cat > test-runtestdir.t <<EOF
> - $TESTDIR, in which test-run-tests.t is placed > - $TESTDIR, in which test-run-tests.t is placed
> - \$TESTDIR, in which test-runtestdir.t is placed (expanded at runtime) > - \$TESTDIR, in which test-runtestdir.t is placed (expanded at runtime)
> - \$RUNTESTDIR, in which run-tests.py is placed (expanded at runtime) > - \$RUNTESTDIR, in which run-tests.py is placed (expanded at runtime)
> >
> #if windows > #if windows
> $ test "\$TESTDIR" = "$TESTTMP\anothertests" > $ test "\$TESTDIR" = "$TESTTMP\\anothertests"
> #else > #else
> $ test "\$TESTDIR" = "$TESTTMP"/anothertests > $ test "\$TESTDIR" = "$TESTTMP"/anothertests
> #endif > #endif
> If this prints a path, that means RUNTESTDIR didn't equal > If this prints a path, that means RUNTESTDIR didn't equal
> TESTDIR as it should have. > TESTDIR as it should have.
> $ test "\$RUNTESTDIR" = "$TESTDIR" || echo "\$RUNTESTDIR" > $ test "\$RUNTESTDIR" = "$TESTDIR" || echo "\$RUNTESTDIR"
> This should print the start of check-code. If this passes but the > This should print the start of check-code. If this passes but the
> previous check failed, that means we found a copy of check-code at whatever > previous check failed, that means we found a copy of check-code at whatever