( )⚙ D11061 windows: use abspath in commandserver

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11061

windows: use abspath in commandserver
ClosedPublic

Authored by marmoute on Jul 10 2021, 1:45 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG27e75b8bf784: windows: use abspath in commandserver
Summary

We replace os.path.abspath with util.abspath. This should solve more "drive
capitalization" issue on Windows.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Jul 10 2021, 1:45 PM
Alphare accepted this revision.Jul 13 2021, 11:39 AM
This revision is now accepted and ready to land.Jul 13 2021, 11:39 AM
marmoute added a commit: rHG27e75b8bf784: windows: use abspath in commandserver.Jul 16 2021, 5:20 AM
Closed by commit rHG27e75b8bf784: windows: use abspath in commandserver (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/commandserver.py (2 lines)

Diff 29119

mercurial/commandserver.py

# developer config: cmdserver.track-log # developer config: cmdserver.track-log
tracked = set(ui.configlist(b'cmdserver', b'track-log')) tracked = set(ui.configlist(b'cmdserver', b'track-log'))
if logpath == b'-' and fp: if logpath == b'-' and fp:
logger = loggingutil.fileobjectlogger(fp, tracked) logger = loggingutil.fileobjectlogger(fp, tracked)
elif logpath == b'-': elif logpath == b'-':
logger = loggingutil.fileobjectlogger(ui.ferr, tracked) logger = loggingutil.fileobjectlogger(ui.ferr, tracked)
else: else:
logpath = os.path.abspath(util.expandpath(logpath)) logpath = util.abspath(util.expandpath(logpath))
# developer config: cmdserver.max-log-files # developer config: cmdserver.max-log-files
maxfiles = ui.configint(b'cmdserver', b'max-log-files') maxfiles = ui.configint(b'cmdserver', b'max-log-files')
# developer config: cmdserver.max-log-size # developer config: cmdserver.max-log-size
maxsize = ui.configbytes(b'cmdserver', b'max-log-size') maxsize = ui.configbytes(b'cmdserver', b'max-log-size')
vfs = vfsmod.vfs(os.path.dirname(logpath)) vfs = vfsmod.vfs(os.path.dirname(logpath))
logger = loggingutil.filelogger( logger = loggingutil.filelogger(
vfs, vfs,
os.path.basename(logpath), os.path.basename(logpath),