( )⚙ D11066 windows: use abspath in subrepoutil

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11066

windows: use abspath in subrepoutil
ClosedPublic

Authored by marmoute on Jul 10 2021, 1:45 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG5cf2059d2647: windows: use abspath in subrepoutil
Summary

We replace os.path.abspath with util.abspath. This should solve more "drive
capitalization" issue on Windows.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Jul 10 2021, 1:45 PM
Alphare accepted this revision.Jul 13 2021, 11:40 AM
This revision is now accepted and ready to land.Jul 13 2021, 11:40 AM
marmoute added a commit: rHG5cf2059d2647: windows: use abspath in subrepoutil.Jul 16 2021, 5:21 AM
Closed by commit rHG5cf2059d2647: windows: use abspath in subrepoutil (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/subrepoutil.py (2 lines)

Diff 29124

mercurial/subrepoutil.py

# C:\>D: # C:\>D:
# D:\>python -c "import os; print os.path.abspath('C:')" # D:\>python -c "import os; print os.path.abspath('C:')"
# C:\some\path # C:\some\path
# #
# D:\>python -c "import os; print os.path.abspath('C:relative')" # D:\>python -c "import os; print os.path.abspath('C:relative')"
# C:\some\path\relative # C:\some\path\relative
if urlutil.hasdriveletter(path): if urlutil.hasdriveletter(path):
if len(path) == 2 or path[2:3] not in br'\/': if len(path) == 2 or path[2:3] not in br'\/':
path = os.path.abspath(path) path = util.abspath(path)
return path return path
if abort: if abort:
raise error.Abort(_(b"default path for subrepository not found")) raise error.Abort(_(b"default path for subrepository not found"))
def newcommitphase(ui, ctx): def newcommitphase(ui, ctx):
# type: (uimod.ui, context.changectx) -> int # type: (uimod.ui, context.changectx) -> int