( )⚙ D11078 sigpipe-remote: check for python version earlier in the script

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11078

sigpipe-remote: check for python version earlier in the script
ClosedPublic

Authored by marmoute on Jul 11 2021, 5:37 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGb2ed9480b34a: sigpipe-remote: check for python version earlier in the script
Summary

The should abort early, using the wrong python is a pretty bad sign.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mtests/testlib/sigpipe-remote.py (10 lines)

Diff 29326

tests/testlib/sigpipe-remote.py

#!/usr/bin/env python3 #!/usr/bin/env python3
from __future__ import print_function from __future__ import print_function
import io import io
import os import os
import subprocess import subprocess
import sys import sys
import time import time
# we cannot use mercurial.testing as long as python2 is not dropped as the test will only install the mercurial module for python2 in python2 run # we cannot use mercurial.testing as long as python2 is not dropped as the test
# will only install the mercurial module for python2 in python2 run
if sys.version_info[0] < 3:
print('SIGPIPE-HELPER: script should run with Python 3', file=sys.stderr)
sys.exit(255)
if isinstance(sys.stdout.buffer, io.BufferedWriter): if isinstance(sys.stdout.buffer, io.BufferedWriter):
print('SIGPIPE-HELPER: script need unbuffered output', file=sys.stderr) print('SIGPIPE-HELPER: script need unbuffered output', file=sys.stderr)
sys.exit(255) sys.exit(255)
DEBUG_FILE = os.environ.get('SIGPIPE_REMOTE_DEBUG_FILE') DEBUG_FILE = os.environ.get('SIGPIPE_REMOTE_DEBUG_FILE')
if DEBUG_FILE is None: if DEBUG_FILE is None:
debug_stream = sys.stderr.buffer debug_stream = sys.stderr.buffer
def write_file(path, content=b''): def write_file(path, content=b''):
with open(path, 'wb') as f: with open(path, 'wb') as f:
f.write(content) f.write(content)
# end of mercurial.testing content # end of mercurial.testing content
if sys.version_info[0] < 3:
print('SIGPIPE-HELPER: script should run with Python 3', file=sys.stderr)
sys.exit(255)
def sysbytes(s): def sysbytes(s):
return s.encode('utf-8') return s.encode('utf-8')
def sysstr(s): def sysstr(s):
return s.decode('latin-1') return s.decode('latin-1')