Page MenuHomePhabricator

test: do not use `which` to find an exec path in the test
ClosedPublic

Authored by marmoute on Jan 12 2022, 9:08 AM.

Details

Summary

Posix is deprecated which in favor of command -v… which does not provide the same feature.
Debian is warning about this deprecation and this get annoying.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jan 12 2022, 9:08 AM

Why are the quotes needed?

baymax updated this revision to Diff 31792.Jan 24 2022, 10:00 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 31806.Jan 24 2022, 11:19 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Why are the quotes needed?

because check-code complains about using "/bin/" in general. however this is a core enough tool for it to not be a problem as far as I understand.

Alphare accepted this revision.Jan 24 2022, 12:03 PM
This revision is now accepted and ready to land.Jan 24 2022, 12:03 PM
baymax updated this revision to Diff 31851.Jan 24 2022, 1:12 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)