This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11983

test: do not use `which` to find an exec path in the test
ClosedPublic

Authored by marmoute on Jan 12 2022, 9:08 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGc95ace94f3ad: test: do not use `which` to find an exec path in the test
Summary

Posix is deprecated which in favor of command -v… which does not provide the same feature.
Debian is warning about this deprecation and this get annoying.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jan 12 2022, 9:08 AM
Alphare added a subscriber: Alphare.Jan 17 2022, 8:23 AM

Why are the quotes needed?

baymax updated this revision to Diff 31792.Jan 24 2022, 10:00 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 31806.Jan 24 2022, 11:19 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute added a comment.Jan 24 2022, 12:01 PM
In D11983#183998, @Alphare wrote:

Why are the quotes needed?

because check-code complains about using "/bin/" in general. however this is a core enough tool for it to not be a problem as far as I understand.

Alphare accepted this revision.Jan 24 2022, 12:03 PM
This revision is now accepted and ready to land.Jan 24 2022, 12:03 PM
baymax updated this revision to Diff 31851.Jan 24 2022, 1:12 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Revision Contents
Changeset List

PathPackages
Mtests/test-run-tests.t (2 lines)

Diff 31961

tests/test-run-tests.t

$ rt() $ rt()
> { > {
> "$PYTHON" $TESTDIR/run-tests.py --with-hg=$HGTEST_REAL_HG -j1 "$@" > "$PYTHON" $TESTDIR/run-tests.py --with-hg=$HGTEST_REAL_HG -j1 "$@"
> } > }
error paths error paths
#if symlink #if symlink
$ ln -s `which true` hg $ ln -s "/"bin"/"true hg
$ "$PYTHON" $TESTDIR/run-tests.py --with-hg=./hg $ "$PYTHON" $TESTDIR/run-tests.py --with-hg=./hg
^warning: --with-hg should specify an hg script, not: (true|coreutils)$ (re) ^warning: --with-hg should specify an hg script, not: (true|coreutils)$ (re)
running 0 tests using 0 parallel processes running 0 tests using 0 parallel processes
# Ran 0 tests, 0 skipped, 0 failed. # Ran 0 tests, 0 skipped, 0 failed.
$ rm hg $ rm hg
#endif #endif