Differential D12061

test-http-bad-server: move on test from bytes-count to pattern
ClosedPublic
Actions

Authored by marmoute on Jan 24 2022, 9:47 AM.

Details

Reviewers

Alphare

Group Reviewers

hg-reviewers

Commits

rHG3e0462ae6230: test-http-bad-server: move on test from bytes-count to pattern

Summary

This specific test case is now using the new "close when a pattern is seen"
approach compared to the more fragile "that many bytes were sent" approach.

Since such change are still a bit noisy, we split each change in there own
changesets.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jan 24 2022, 9:47 AM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptJan 24 2022, 9:47 AM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

marmoute added a child revision: D12062: test-http-bad-server: move on test from bytes-count to pattern.Jan 24 2022, 9:47 AM

Alphare accepted this revision.Jan 24 2022, 10:33 AM

This revision is now accepted and ready to land.Jan 24 2022, 10:33 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute added a commit: rHG3e0462ae6230: test-http-bad-server: move on test from bytes-count to pattern.Jan 25 2022, 4:20 AM

Closed by commit rHG3e0462ae6230: test-http-bad-server: move on test from bytes-count to pattern (authored by marmoute). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			tests/test-http-bad-server.t (30 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	31764		Jan 24 2022, 9:47 AM	★	★
Diff 2	31885		Jan 24 2022, 1:18 PM	★	★
Diff 3	31937	rHG3e0462ae6230485e308cfe05302445c48a628e6a	Jan 21 2022, 11:06 AM	★	★

Status	Author	Revision
Closed	marmoute	D11997 share-safe: enable by default (BC)
Closed	marmoute	D11996 share-safe: add support for static-http repository
Closed	marmoute	D11995 legacy-revlog: fix requirement computation when cloning legacy repo
Closed	marmoute	D11994 requirements: do not warn about dropping share-safe, unless explicitly set
Closed	marmoute	D11993 sparse: take lock before writing requirements
Closed	marmoute	D11992 largefiles: take lock before writing requirements
Closed	marmoute	D11991 lfs: take lock before writing requirements
Closed	marmoute	D11990 test: simpler requirements matching in test-repo-compengines.t
Closed	marmoute	D11989 test: simpler requirements matching in test-lfs-largefiles.t
Closed	marmoute	D11988 test: simpler requirements matching in test-sidedata.t
Closed	marmoute	D11987 test: simpler requirement matching in test-revlog-v2.t
Closed	marmoute	D11986 test-copies: narrow the format check in test-copies-in-changeset.t
Closed	marmoute	D11985 tests: use debugrequires instead of grepping the file directly
Closed	marmoute	D11984 tests: use debugrequires in test-upgrade-repo.t
Closed	marmoute	D11983 test: do not use `which` to find an exec path in the test
Closed	marmoute	D11982 stream-clone: stop considering working copy only requirements
Closed	marmoute	D12084 stream-clone: also filter the requirement we put in the bundle 2
Closed	marmoute	D12083 requirements: add an official `REVLOG_COMPRESSION_ZSTD` const
Closed	marmoute	D12082 stream-requirements: smoother matching in test-http-protocol.t
Closed	marmoute	D12081 stream-requirements: smoother matching in test-ssh-bundle1.t
Closed	marmoute	D12080 stream-requirements: smoother matching in test-ssh-proto.t
Closed	marmoute	D12079 stream-requirements: smoother matching in test-hgweb-commands.t
Closed	marmoute	D12078 stream-requirements: smoother matching in test-treemanifest.t
Closed	marmoute	D12077 stream-requirements: smoother matching in test-ssh-proto-unbundle.t
Closed	marmoute	D12076 test-bundle: split some variant in there own section
Closed	marmoute	D12075 test-bundle: split each variant in there own section
Closed	marmoute	D12074 test-http-bad-server: abstract the `streamreqs` value
Closed	marmoute	D12073 test-http-bad-server: use the new pattern-reading for a test-case
Closed	marmoute	D12072 test-http-bad-server: use the new pattern-reading for a test-case
Closed	marmoute	D12071 test-http-bad-server: use the new pattern-reading for a test-case
Closed	marmoute	D12070 test-http-bad-server: use the new pattern-reading for a test-case
Closed	marmoute	D12069 test-http-bad-server: use the new pattern-reading for a test-case
Closed	marmoute	D12068 test-http-bad-server: introduce socket closing after reading a pattern
Closed	marmoute	D12067 test-http-bad-server: move on test from bytes-count to pattern
Closed	marmoute	D12066 test-http-bad-server: move on test from bytes-count to pattern
Closed	marmoute	D12065 test-http-bad-server: move on test from bytes-count to pattern
Closed	marmoute	D12064 test-http-bad-server: move on test from bytes-count to pattern
Closed	marmoute	D12063 test-http-bad-server: move on test from bytes-count to pattern
Closed	marmoute	D12062 test-http-bad-server: move on test from bytes-count to pattern
Closed	marmoute	D12061 test-http-bad-server: move on test from bytes-count to pattern
Closed	marmoute	D12060 test-http-bad-server: move on test from bytes-count to pattern
Closed	marmoute	D12059 test-http-bad-server: move on test from bytes-count to pattern
Closed	marmoute	D12058 test-http-bad-server: move on test from bytes-count to pattern
Closed	marmoute	D12057 test-http-bad-server: move on test from bytes-count to pattern
Closed	marmoute	D12056 test-http-bad-server: move on test from bytes-count to pattern
Closed	marmoute	D12055 test-http-bad-server: move on test from bytes-count to pattern
Closed	marmoute	D12054 test-http-bad-server: modify some `tail` call fit their goal
Closed	marmoute	D12053 test-http-bad-server: move on test from bytes-count to pattern
Closed	marmoute	D12052 test-http-bad-server: move on test from bytes-count to pattern
Closed	marmoute	D12051 test-http-bad-server: move on test from bytes-count to pattern
Closed	marmoute	D12050 test-http-bad-server: move on test from bytes-count to pattern
Closed	marmoute	D12049 test-bad-http-server: introduce sock closing when writing a pattern
Closed	marmoute	D12048 test-http-bad-server: document that the value are actually a list
Closed	marmoute	D12047 test-http-bad-server: refactor the writing logic to avoid early return
Closed	marmoute	D12046 test-http-bad-server: replace the default 65537 value in output
Closed	marmoute	D12045 test-http-bad-server: refactor the reading logic to avoid early return
Closed	marmoute	D12044 test-http-bad-server: factor code dealing with "read" in the new object
Closed	marmoute	D12043 test-http-bad-server: factor code dealing with "write" in the new object
Closed	marmoute	D12042 test-http-bad-server: unify log printing for `sendall` and `write`
Closed	marmoute	D12041 test-http-bad-server: track close condition in an object
Closed	marmoute	D12040 test-http-bad-server: use more readable name for variable
Closed	marmoute	D12039 test-http-bad-server: align output by using `;`
Closed	marmoute	D12038 test-http-bad-server: highlight each test with section
Closed	marmoute	D12037 test-http-bad-server: rename config to use `-`
Closed	marmoute	D12036 test-http-bad-server: move the extension in `testlib`
Closed	marmoute	D12035 requirements: remove the `localrepo.supportedformat` attribute
Closed	marmoute	D12034 requirements: sort _basesupported
Closed	marmoute	D12033 requirements: move the comment about manifestv2 in the module
Closed	marmoute	D12032 stream-clone: add a explicit set list requirements relevant to stream clone
Closed	marmoute	D12031 stream-clone: filter possible missing requirements using all supported one
Closed	marmoute	D12030 requirements: move "bookmark in store" requirements in the right module
Closed	marmoute	D12029 stream-clone: add a explicit test for format change during stream clone
Closed	marmoute	D12028 stream-clone: factor computation of requirement of a stream clone
Closed	marmoute	D12027 stream-clone: factor computation of new clone requirement out
Closed	marmoute	D12026 stream-clone: drop some outdated lines in test-stream-bundle-v2.t

Diff 31937

View Options

tests/test-http-bad-server.t

test-http-bad-server: move on test from bytes-count to patternClosedPublicActions