Page MenuHomePhabricator

requirements: add an official `REVLOG_COMPRESSION_ZSTD` const
ClosedPublic

Authored by marmoute on Jan 24 2022, 9:51 AM.

Details

Summary

Such constant was missing and its value was missing from the set of requirements
that needs to be preserved through stream clone. This did not had any
consequence yet as the "bundle 2 does not filter its requirements" is shadowing
the issue.

However we are now in a situation where we can fix this issue. So lets do it
next.

With the preparation work on test, changing the streamreqs value only impact two
tests, where checking the full value seems to remains relevant.

Important note: Since older version of Mercurial used the old supportedformat
class attribute to check for stream requirement they supported, older version
will consider this requirements to prevent them from using streaming clone. Even
as they support this requirements for years. Pack for stable will be send to fix
it, but they will have to be backported to older version if needed.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jan 24 2022, 9:51 AM
Alphare accepted this revision.Jan 24 2022, 11:17 AM
Alphare added a subscriber: Alphare.

When you send the patch for stable we can think about telling the packaging list about this issue?

This revision is now accepted and ready to land.Jan 24 2022, 11:17 AM

When you send the patch for stable we can think about telling the packaging list about this issue?

This is 110% my plan.

baymax updated this revision to Diff 31848.Jan 24 2022, 1:11 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)