Page MenuHomePhabricator

test-http-bad-server: unify log printing for `sendall` and `write`
ClosedPublic

Authored by marmoute on Jan 24 2022, 9:45 AM.

Details

Summary

The write function was logging before calling the function while the sendall
function were logging after calling the function.

We align the write behavior on the sendall behavior before unifying the
code.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jan 24 2022, 9:45 AM
Alphare accepted this revision.Jan 24 2022, 10:00 AM
This revision is now accepted and ready to land.Jan 24 2022, 10:00 AM
baymax retitled this revision from test-http-bad-server: unify log printing for `sendall` and `write`o to test-http-bad-server: unify log printing for `sendall` and `write`.Jan 24 2022, 1:16 PM
baymax updated this revision to Diff 31866.

✅ refresh by Heptapod after a successful CI run (🐙 💚)