Differential D12042

test-http-bad-server: unify log printing for `sendall` and `write`
ClosedPublic
Actions

Authored by marmoute on Jan 24 2022, 9:45 AM.

Tags

None

Subscribers

mercurial-patches

Details

Reviewers

Group Reviewers

Commits

rHGf91f98e9834a: test-http-bad-server: unify log printing for `sendall` and `write`

Summary

The write function was logging before calling the function while the sendall
function were logging after calling the function.

We align the write behavior on the sendall behavior before unifying the
code.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jan 24 2022, 9:45 AM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptJan 24 2022, 9:45 AM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

marmoute added a child revision: D12043: test-http-bad-server: factor code dealing with "write" in the new object.Jan 24 2022, 9:45 AM

Alphare accepted this revision.Jan 24 2022, 10:00 AM

This revision is now accepted and ready to land.Jan 24 2022, 10:00 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute added a commit: rHGf91f98e9834a: test-http-bad-server: unify log printing for `sendall` and `write`.Jan 25 2022, 4:18 AM

Closed by commit rHGf91f98e9834a: test-http-bad-server: unify log printing for `sendall` and `write` (authored by marmoute). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			tests/test-http-bad-server.t (56 lines)
M			tests/testlib/badserverext.py (6 lines)

Diff 31918

tests/test-http-bad-server.t

Loading...

tests/testlib/badserverext.py

Loading...