( )⚙ D12058 test-http-bad-server: move on test from bytes-count to pattern

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12058

test-http-bad-server: move on test from bytes-count to pattern
ClosedPublic

Authored by marmoute on Jan 24 2022, 9:47 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG26105e9b0487: test-http-bad-server: move on test from bytes-count to pattern
Summary

This specific test case is now using the new "close when a pattern is seen"
approach compared to the more fragile "that many bytes were sent" approach.

Since such change are still a bit noisy, we split each change in there own
changesets.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Jan 24 2022, 9:47 AM
Alphare accepted this revision.Jan 24 2022, 10:31 AM
This revision is now accepted and ready to land.Jan 24 2022, 10:31 AM
baymax updated this revision to Diff 31882.Jan 24 2022, 1:18 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Revision Contents
Changeset List

PathPackages
Mtests/test-http-bad-server.t (22 lines)

Diff 31882

tests/test-http-bad-server.t

Exception: connection closed after sending N bytes Exception: connection closed after sending N bytes
$ rm -f error.log $ rm -f error.log
Server sends partial bundle2 header magic Server sends partial bundle2 header magic
----------------------------------------- -----------------------------------------
$ hg serve --config badserver.close-after-send-bytes=980 -p $HGPORT -d --pid-file=hg.pid -E error.log $ hg serve \
> --config badserver.close-after-send-patterns='4\r\nHG2' \
> -p $HGPORT -d --pid-file=hg.pid -E error.log
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
$ hg clone http://localhost:$HGPORT/ clone $ hg clone http://localhost:$HGPORT/ clone
requesting all changes requesting all changes
abort: HTTP request error (incomplete response) (py3 !) abort: HTTP request error (incomplete response) (py3 !)
abort: HTTP request error (incomplete response; expected 4 bytes got 3) (no-py3 !) abort: HTTP request error (incomplete response; expected 4 bytes got 3) (no-py3 !)
(this may be an intermittent network failure; if the error persists, consider contacting the network or server operator) (this may be an intermittent network failure; if the error persists, consider contacting the network or server operator)
[255] [255]
$ killdaemons.py $DAEMON_PIDS $ killdaemons.py $DAEMON_PIDS
#if py36 #if py36
$ "$PYTHON" $TESTDIR/filtertraceback.py < error.log | tail -9 $ "$PYTHON" $TESTDIR/filtertraceback.py < error.log | tail -9
sendall(167 from 167) -> (21) HTTP/1.1 200 Script output follows\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nContent-Type: application/mercurial-0.2\r\nTransfer-Encoding: chunked\r\n\r\n sendall(167) -> HTTP/1.1 200 Script output follows\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nContent-Type: application/mercurial-0.2\r\nTransfer-Encoding: chunked\r\n\r\n
sendall(6 from 6) -> (15) 1\\r\\n\x04\\r\\n (esc) sendall(6) -> 1\\r\\n\x04\\r\\n (esc)
sendall(9 from 9) -> (6) 4\r\nnone\r\n sendall(9) -> 4\r\nnone\r\n
sendall(6 from 9) -> (0) 4\r\nHG2 sendall(6 from 9) -> (0) 4\r\nHG2
write limit reached; closing socket write limit reached; closing socket
$LOCALIP - - [$ERRDATE$] Exception happened during processing request '/?cmd=getbundle': (glob) $LOCALIP - - [$ERRDATE$] Exception happened during processing request '/?cmd=getbundle': (glob)
Traceback (most recent call last): Traceback (most recent call last):
Exception: connection closed after sending N bytes Exception: connection closed after sending N bytes
#else #else
$ "$PYTHON" $TESTDIR/filtertraceback.py < error.log | tail -11 $ "$PYTHON" $TESTDIR/filtertraceback.py < error.log | tail -11
readline(~) -> (2) \r\n (py3 !) readline(~) -> (2) \r\n (py3 !)
write(167 from 167) -> (21) HTTP/1.1 200 Script output follows\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nContent-Type: application/mercurial-0.2\r\nTransfer-Encoding: chunked\r\n\r\n (py3 !) write(167) -> HTTP/1.1 200 Script output follows\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nContent-Type: application/mercurial-0.2\r\nTransfer-Encoding: chunked\r\n\r\n (py3 !)
write(41 from 41) -> (51) Content-Type: application/mercurial-0.2\r\n write(41) -> Content-Type: application/mercurial-0.2\r\n (no-py3 !)
write(28 from 28) -> (23) Transfer-Encoding: chunked\r\n write(28) -> Transfer-Encoding: chunked\r\n (no-py3 !)
write(2 from 2) -> (21) \r\n write(2) -> \r\n (no-py3 !)
write(6 from 6) -> (15) 1\\r\\n\x04\\r\\n (esc) write(6) -> 1\\r\\n\x04\\r\\n (esc)
write(9 from 9) -> (6) 4\r\nnone\r\n write(9) -> 4\r\nnone\r\n
write(6 from 9) -> (0) 4\r\nHG2 write(6 from 9) -> (0) 4\r\nHG2
write limit reached; closing socket write limit reached; closing socket
$LOCALIP - - [$ERRDATE$] Exception happened during processing request '/?cmd=getbundle': (glob) $LOCALIP - - [$ERRDATE$] Exception happened during processing request '/?cmd=getbundle': (glob)
Traceback (most recent call last): Traceback (most recent call last):
Exception: connection closed after sending N bytes Exception: connection closed after sending N bytes
#endif #endif