This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2139

py3: pass system string to socket.getservbyname
ClosedPublic

Authored by indygreg on Feb 11 2018, 5:57 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG15c8c4ac5d9c: py3: pass system string to socket.getservbyname
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 11 2018, 5:57 PM
Closed by commit rHG15c8c4ac5d9c: py3: pass system string to socket.getservbyname (authored by indygreg). · Explain WhyFeb 11 2018, 8:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/util.py (2 lines)

Diff 5440

mercurial/util.py

service, error.Abort is raised. service, error.Abort is raised.
""" """
try: try:
return int(port) return int(port)
except ValueError: except ValueError:
pass pass
try: try:
return socket.getservbyname(port) return socket.getservbyname(pycompat.sysstr(port))
except socket.error: except socket.error:
raise Abort(_("no port number associated with service '%s'") % port) raise Abort(_("no port number associated with service '%s'") % port)
_booleans = {'1': True, 'yes': True, 'true': True, 'on': True, 'always': True, _booleans = {'1': True, 'yes': True, 'true': True, 'on': True, 'always': True,
'0': False, 'no': False, 'false': False, 'off': False, '0': False, 'no': False, 'false': False, 'off': False,
'never': False} 'never': False}
def parsebool(s): def parsebool(s):