Page MenuHomePhabricator

py3: use raw string for open() mode
Needs ReviewPublic

Authored by indygreg on Feb 11 2018, 9:35 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Feb 11 2018, 9:35 PM
pulkit added a subscriber: pulkit.Feb 12 2018, 2:33 AM

Looks like a better approach will be to revert this change: https://www.mercurial-scm.org/repo/hg/rev/7c54917b31f6. I did that in favor of pycompat.open() and now I think it's better to revert that change.

yuja added a subscriber: yuja.Feb 12 2018, 5:41 AM

I wanna leave it with no prefix as possible. I think we'll have to bulk-replace
''s to b''s at some point so we can leverage static analysis tools, where
r'' will be unneeded.