This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2164

py3: avoid changing dictionary during iteration
ClosedPublic

Authored by indygreg on Feb 11 2018, 9:35 PM.

Details

Reviewers
pulkit
durin42
Group Reviewers
hg-reviewers
Commits
rHGc02771617a70: py3: avoid changing dictionary during iteration
Summary

dict.items() and friends are iterators/views in Python 3. You
aren't allowed to mutate the underlying dictionary when iterating
on these views. So iterate over a copy of things.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 11 2018, 9:35 PM
pulkit accepted this revision.Feb 12 2018, 2:37 AM
durin42 accepted this revision.Feb 12 2018, 9:31 PM
This revision is now accepted and ready to land.Feb 12 2018, 9:31 PM
Closed by commit rHGc02771617a70: py3: avoid changing dictionary during iteration (authored by indygreg). · Explain WhyFeb 12 2018, 9:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/copies.py (2 lines)

Diff 5588

mercurial/copies.py

if v not in dst: if v not in dst:
# chain was a rename, not a copy # chain was a rename, not a copy
del t[v] del t[v]
if v in src: if v in src:
# file is a copy of an existing file # file is a copy of an existing file
t[k] = v t[k] = v
# remove criss-crossed copies # remove criss-crossed copies
for k, v in t.items(): for k, v in list(t.items()):
if k in src and v in dst: if k in src and v in dst:
del t[k] del t[k]
return t return t
def _tracefile(fctx, am, limit=-1): def _tracefile(fctx, am, limit=-1):
"""return file context that is the ancestor of fctx present in ancestor """return file context that is the ancestor of fctx present in ancestor
manifest am, stopping after the first ancestor lower than limit""" manifest am, stopping after the first ancestor lower than limit"""